Add linkify-user-edit-history-popup feature
#3412
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,32 @@ | ||||||
| import React from 'dom-chef'; | ||||||
| import {observe} from 'selector-observer'; | ||||||
| import * as pageDetect from 'github-url-detection'; | ||||||
|
|
||||||
| import features from '.'; | ||||||
| import {wrap} from '../helpers/dom-utils'; | ||||||
|
|
||||||
| function init(): void { | ||||||
| observe('details-dialog .Box-header .mr-3 > img:not([alt*="[bot]"])', { | ||||||
| add(avatar) { | ||||||
| const userName = (avatar as HTMLImageElement).alt.slice(1); | ||||||
| // Linkify name first | ||||||
| wrap(avatar.nextElementSibling!, <a className="link-gray-dark" href={`/${userName}`}/>); | ||||||
|
|
||||||
| // Then linkify avatar | ||||||
| wrap(avatar, <a href={`/${userName}`}/>); | ||||||
| } | ||||||
| }); | ||||||
| } | ||||||
|
|
||||||
| void features.add({ | ||||||
| id: __filebasename, | ||||||
| description: 'Linkifies the username in the edit history popup.', | ||||||
| screenshot: 'https://user-images.githubusercontent.com/1402241/88917988-9ebb7480-d260-11ea-8690-0a3440f1ebbc.png' | ||||||
| }, { | ||||||
| init, | ||||||
| include: [ | ||||||
| pageDetect.isIssue, | ||||||
| pageDetect.isPRConversation | ||||||
| ], | ||||||
| repeatOnAjax: false | ||||||
|
Member
There was a problem hiding this comment. I realized that this can be improved (separately). The logic shouldn't be "repeat on ajax", but just "don't run more than once"
Suggested change
This would solve the issues we had elsewhere because |
||||||
| }); | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do it later today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or as part of a
lintPR :D