Skip to content

Conversation

@kidonng
Copy link
Member

@kidonng kidonng commented Jul 28, 2020

Note format-conversation-titles will be removed in #3409

@fregante fregante changed the title Move backtick parsing in format-conversation-titles Move backtick parsing in format-conversation-titles test Jul 28, 2020
@fregante fregante changed the title Move backtick parsing in format-conversation-titles test Move backtick parsing in format-conversation-titles Jul 28, 2020
@fregante fregante changed the title Move backtick parsing in format-conversation-titles Move backtick parsing in format-conversation-titles test Jul 28, 2020
@fregante
Copy link
Member

This doesn't seem to work like the rest of ajaxed GH pieces. The title has its specific update function that just changes the textContent, making which is invisible to our new observer

u(n, '.js-issue-title').textContent = o.issue_title;

@fregante fregante closed this Jul 28, 2020
@fregante fregante changed the title Move backtick parsing in format-conversation-titles test Move backtick parsing in format-conversation-titles Jul 28, 2020
@fregante
Copy link
Member

format-conversation-titles should probably be excluded from #3409 as well.

If anything, format-conversation-titles should be fixed because the title isn't re-parsed when the title is changed

@kidonng kidonng deleted the parse-backticks branch August 9, 2020 15:20
@kidonng
Copy link
Member Author

kidonng commented Aug 13, 2020

#3458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants