Apply linkify-code to unfolded diffs
#3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
This comment has been minimized.
This comment has been minimized.
Member
|
I think this only needs to remove mentions of the issue title since that widget is incompatible with The rest seems correct |
Member
Member
Author
Member
|
Can you look into this as well? #3226 What's going on? Is the selector wrong? |
fregante
approved these changes
Aug 10, 2020
Member
|
Congratulations for solving the oldest open bug 🍰 |
Member
|
Can you try restoring the laziness from https://github.com/sindresorhus/refined-github/pull/3091/files? I think my code only lacked the |
Member
Author
Yeah, need to narrow it down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3084 (if I should mention it)
Resolves #2091
Test: https://github.com/sindresorhus/refined-github/pull/636/files (unfold the diff above)
This PR simply warp the old code with
selector-observerand add an additional selector (.blob-expanded) to make it work on unfolded diffs.Mergeformat-conversation-titlesin this PR as well (on request by #3397 (comment))