Add `clean-conversation-headers` feature #3408

kidonng · 2020-07-27T16:57:12Z

Resolves #3089

Open issue

Test: https://github.com/sindresorhus/refined-github/issues/14

Note: if someone just created a PR to close the issue or someone edited currently displayed PR, GitHub will update the header and this feature won't reapply

Open issue with pending PR

Test: https://github.com/sindresorhus/refined-github/issues/343

Closed issue

Test: https://github.com/sindresorhus/refined-github/issues/3370

Open PR (to default branch)

Test: https://github.com/sindresorhus/refined-github/pull/3227

Open PR (to non-default branch)

Test: https://github.com/Kenshin/simpread/pull/698

Merged PR (same author, to default branch)

Test: https://github.com/sindresorhus/refined-github/pull/3402

Merged PR (different author, to default branch)

Test: https://github.com/sindresorhus/refined-github/pull/3033

kidonng · 2020-07-27T18:00:07Z

~~Concern: hiding base ref will lose the ability to switch base~~ Fixed

yakov116 · 2020-07-27T18:14:09Z

Your hiding it or removing it?

kidonng · 2020-07-27T18:15:08Z

Your hiding it or removing it?

Actually remove it

I'm thinking about if you ~~are the author of~~ have permission to edit an open PR, the base will still display

yakov116 · 2020-07-27T18:20:59Z

That will break a few features
enable-file-links-in-compare-view and cross-deleted-pr-branches

kidonng · 2020-07-27T18:27:18Z

Actually it's slicing and replacing, it should not affect existing features (except the switch base one I mentioned)

cross-deleted-pr-branches

See the screenshot it's still working

source/features/clean-conversation-headers.tsx

kidonng · 2020-07-27T19:28:38Z

I figured out if the switch base dropdown isn't removed, it still works even if you remove the base branch text

kidonng · 2020-07-27T19:51:38Z

Note the PR author is always shown if you are not on the conversation list

About the screenshot, there are too many situations to show, maybe just pick some from #3089?

fregante · 2020-07-30T11:13:59Z

About the screenshot, there are too many situations to show, maybe just pick some from #3089?

Use a PR and make a before/after view of the header

source/features/clean-conversation-headers.tsx

fregante · 2020-08-08T11:51:21Z

I hope to see this merged soon!

kidonng · 2020-08-08T12:12:44Z

😁 Yeah I will finish these PR today (or tomorrow), just submitted 3 PR to different icon extensions fixing compatibility with Refined GitHub.

fregante

I haven't tested it yet, but the rest seems ok

source/features/clean-conversation-headers.tsx

fregante · 2020-08-09T18:46:08Z

source/features/clean-conversation-headers.tsx

+
+			// Removes: [octocat opened this issue on 1 Jan] · 1 comments
+			for (const node of Array.from(childNodes).slice(0, 4)) {
+				node.remove();


I think it's best to also hide this

Suggested change

node.remove();

node.hidden = true;

There is a text node

source/features/clean-conversation-headers.tsx

fregante · 2020-08-10T10:12:18Z

I think that many features using selector-observer can use waitForDomReady: false

fregante

Seems to work great! except waitForDomReady

Can you (always) provide testing links? Especially for rare situations like non-default base branch PRs

yakov116 · 2020-08-18T12:30:15Z

I get

refined-github.js:18097 Uncaught (in promise) TypeError: Cannot read property 'textContent' of null
    at getBranches (refined-github.js:18097)
    at MutationObserver.addButton (refined-github.js:18152)
getBranches @ refined-github.js:18097
addButton @ refined-github.js:18152
childList (async)
(anonymous) @ updatable-content.ts:79
he @ scroll-anchoring.esm.js:43
me @ scroll-anchoring.esm.js:2
ve @ updatable-content.ts:60
u @ updatable-content.ts:39
async function (async)
u @ updatable-content.ts:24
setTimeout (async)
(anonymous) @ updatable-content-observer.ts:22
cs @ socket-channel.ts:43
receive @ socket-channel.ts:93
AliveSessionProxy.worker.port.onmessage @ socket-channel.ts:61

refined-github.js:7305 Uncaught TypeError: Cannot read property 'textContent' of null
    at add (refined-github.js:7305)
    at runAdd (refined-github.js:3558)
    at applyChanges (refined-github.js:3474)
    at SelectorObserver.handleRootMutations (refined-github.js:4000)

When I open a new pr and I get errors if you switch tabs too quickly

kidonng · 2020-08-27T18:26:29Z

Can you (always) provide testing links? Especially for rare situations like non-default base branch PRs

Late reply: I forgot to include the URL when I uploaded the screenshots 😅 already added them to make future debug easier

fregante · 2020-08-27T21:55:34Z

Thanks! Especially when adding new features, PRs serve as documentation for the feature, so it's great to be able to open the original PR and instantly see what it was supposed to look like and where exactly

kidonng added 2 commits July 28, 2020 00:56

Add clean-conversation-headers feature

77b359e

Fix pending PR and other possible additional meta

11da68a

kidonng changed the title ~~Add clean-conversation-headers feature~~ Add clean-conversation-headers feature Jul 27, 2020

Finish

e4a24d1

kidonng marked this pull request as ready for review July 27, 2020 18:13

kidonng marked this pull request as draft July 27, 2020 18:30

fregante reviewed Jul 27, 2020

View reviewed changes

source/features/clean-conversation-headers.tsx Outdated Show resolved Hide resolved

fregante reviewed Jul 27, 2020

View reviewed changes

source/features/clean-conversation-headers.tsx Outdated Show resolved Hide resolved

Rewrite initIssue

182c21c

fregante added the enhancement label Jul 27, 2020

Rewrite initPR

8b965a0

kidonng added 3 commits July 28, 2020 03:29

Lint

b90de88

Merge branch 'master' into clean-conversation-headers

c14aa95

Use selector-observer cause why not

4b03605

kidonng marked this pull request as ready for review July 27, 2020 19:46

meta

dfd8463

Prepend

621c78f

kidonng marked this pull request as draft July 29, 2020 17:47

fregante reviewed Jul 31, 2020

View reviewed changes

source/features/clean-conversation-headers.tsx Outdated Show resolved Hide resolved

source/features/clean-conversation-headers.tsx Outdated Show resolved Hide resolved

Merge branch 'master' into clean-conversation-headers

c34c8ac

kidonng added 3 commits August 9, 2020 23:33

Hide instead of remove base branch

0654416

Fix selector and add comments

f3a639e

Add screenshot

772e264

kidonng marked this pull request as ready for review August 9, 2020 16:17

fregante reviewed Aug 9, 2020

View reviewed changes

👀

e2ac95f

fregante approved these changes Aug 10, 2020

View reviewed changes

fregante added 2 commits August 13, 2020 14:40

Merge branch 'master' into clean-conversation-headers

50273ac

Add waitForDomReady: false and rename variables

5aa8a81

fregante merged commit 6bba1c5 into refined-github:master Aug 13, 2020

fregante mentioned this pull request Aug 13, 2020

Highlight a PR's base branch if it's not the default #3461

Closed

yakov116 mentioned this pull request Aug 18, 2020

Lint #3478

Merged

kidonng deleted the clean-conversation-headers branch August 24, 2020 13:06

Uh oh!

Add clean-conversation-headers feature #3408

Add clean-conversation-headers feature #3408

Uh oh!

Conversation

kidonng commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Open issue

Open issue with pending PR

Closed issue

Open PR (to default branch)

Open PR (to non-default branch)

Merged PR (same author, to default branch)

Merged PR (different author, to default branch)

Uh oh!

kidonng commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yakov116 commented Jul 27, 2020

Uh oh!

kidonng commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yakov116 commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidonng commented Jul 27, 2020

Uh oh!

Uh oh!

Uh oh!

kidonng commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidonng commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented Jul 30, 2020

Uh oh!

Uh oh!

Uh oh!

fregante commented Aug 8, 2020

Uh oh!

kidonng commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

kidonng Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fregante commented Aug 10, 2020

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

yakov116 commented Aug 18, 2020

Uh oh!

kidonng commented Aug 27, 2020

Uh oh!

fregante commented Aug 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Add `clean-conversation-headers` feature #3408

Add `clean-conversation-headers` feature #3408

kidonng commented Jul 27, 2020 •

edited

Loading

kidonng commented Jul 27, 2020 •

edited

Loading

kidonng commented Jul 27, 2020 •

edited

Loading

yakov116 commented Jul 27, 2020 •

edited

Loading

kidonng commented Jul 27, 2020 •

edited

Loading

kidonng commented Jul 27, 2020 •

edited

Loading

kidonng commented Aug 8, 2020 •

edited

Loading