Restore `edit-comments-faster` on review comments by kidonng · Pull Request #3407 · refined-github/refined-github

kidonng · 2020-07-27T16:37:24Z

Maybe a continuation of #2992

Obsolete information

Explanation of the lazy load logic mentioned in #3396

.js-minimizable-comment-group
	.minimized-comment // Invisible
		...
			details-menu
				.js-comment-edit-button // A
    .js-comment
		...
			details-menu[src]
				// Contents are lazy loaded when you hover the three dots menu
				.js-comment-edit-button // B

Why Up arrow to edit own comment is broken #3388 happens: comment-fields-keyboard-shortcuts tries to find B which isn't loaded yet
Why edit-comments-faster in review comments doesn't work: only A triggers the function and the icon is added into an invisible container
Why Up arrow to edit own comment is broken #3388 (comment) happens: B loads and triggers the function and the icon is added into an invisible container

This PR

~~Determine if it's A triggering the function, and add the edit icon to the correct location in review comments (fix 2)~~
~~Skip if it's B triggering the function, to prevent duplicate icon addition (fix 3)~~
Upgrade to selector-observer, fix "Edit comment" button injection is not reliable #3279
Rewrite the feature to fix existing issues

Test: A PR with review comments (like https://github.com/sindresorhus/refined-github/pull/3405#discussion_r460863841)

source/features/edit-comments-faster.tsx

fregante · 2020-07-27T18:48:19Z

This seems unnecessary. As I suggested earlier, the solution is to create a brand-new button instead of cloning the existing one. This way you just need to select the emoji dropdown and avoid all this document traversing/filtering.

kidonng · 2020-07-27T21:09:57Z

Filtering is needed because there can be two edit buttons in a single review comment.

Check out the latest code, maybe the simplest one.

fregante · 2020-07-29T16:21:20Z

Please always provide a link where this is testable, as requested in the PR template.

And what it fixes exactly

kidonng · 2020-07-29T17:35:25Z

Sorry, added test link and make what this PR does more clear.

I just found there are still rooms for improvement: currently it doesn't work if you unresolve a conversation

kidonng · 2020-08-02T17:17:33Z

Seems like GitHub removed the aforementioned lazy load logic, so this bug doesn't exist anymore. Closing for the moment.

Update on 2020-08-24: it is back 😥

kidonng · 2020-08-28T08:01:01Z

After using selector-observer it works for unresolved conversations 🎉

fregante · 2020-08-28T08:02:28Z

I'm still seeing the lazy-loaded context-menus. For the 3rd time, do not use cloneNode. Just generate the link via JSX.

kidonng · 2020-08-28T08:03:41Z

I'm still seeing the lazy-loaded context-menus

That's why I reopened this PR (though it now also includes upgrading to selector-observer)

For the 3rd time, do not use cloneNode

🤷‍♀️ That cloneNode is not written by me

source/features/edit-comments-faster.tsx

fregante

Thank you!

Note: hasComment automatically implies a comment event listener though. This has no effect since we use onetime, but we should keep it in mind.

Perhaps we can remove that implication once we refactor every/most hasComments feature to use selector-observer

kidonng · 2020-10-07T07:31:38Z

I reverted 9c147cd with new selectors. Tested on other repos where I have permissions, the edit button appears on where it should.

source/features/edit-comments-faster.tsx

fregante · 2020-10-07T22:31:57Z

2.3 months in the making

🥳

yakov116 · 2020-10-12T12:24:14Z

Not sure what broke here. After this PR on #3621 only the first comment has a edit icon. the rest throw a whole bunch of console errors.

fregante · 2020-10-13T22:54:43Z

Hidden comments break the feature because they have no reaction button. The observe selector needs to be updated

Co-authored-by: Federico <me@fregante.com>

kidonng added 2 commits July 28, 2020 00:17

Fix edit-comments-faster in review comments

3e5fb20

Lint

1d3e63a

fregante reviewed Jul 27, 2020

View reviewed changes

source/features/edit-comments-faster.tsx Outdated Show resolved Hide resolved

fregante added the bug label Jul 27, 2020

fregante marked this pull request as draft July 27, 2020 19:05

kidonng added 2 commits July 28, 2020 04:49

Shorten

fc21a65

Nope

0457658

kidonng marked this pull request as ready for review July 27, 2020 21:06

fregante marked this pull request as draft July 29, 2020 16:12

kidonng closed this Aug 2, 2020

kidonng deleted the edit-comments-faster branch August 9, 2020 15:15

kidonng restored the edit-comments-faster branch August 24, 2020 11:53

kidonng reopened this Aug 24, 2020

kidonng added 2 commits August 28, 2020 15:41

Merge branch 'master' into edit-comments-faster

d1aabe6

Use selector observer

5942cf4

kidonng marked this pull request as ready for review August 28, 2020 07:59

fregante marked this pull request as draft August 28, 2020 08:02

fregante reviewed Aug 28, 2020

View reviewed changes

source/features/edit-comments-faster.tsx Outdated Show resolved Hide resolved

fregante marked this pull request as ready for review August 28, 2020 08:08

Directly attach button

9c147cd

fregante changed the title ~~Fix edit-comments-faster in review comments~~ Fix edit-comments-faster for review comments Aug 29, 2020

fregante approved these changes Aug 29, 2020

View reviewed changes

fregante closed this Sep 9, 2020

fregante reopened this Sep 25, 2020

fregante removed the selector-observer label Sep 25, 2020

fregante marked this pull request as draft September 25, 2020 01:15

fregante removed the do not merge yet label Sep 25, 2020

Use new selectors

19f36b4

kidonng force-pushed the edit-comments-faster branch from 757cd6f to 19f36b4 Compare October 7, 2020 07:23

kidonng marked this pull request as ready for review October 7, 2020 07:30

kidonng requested a review from fregante October 7, 2020 14:36

fregante reviewed Oct 7, 2020

View reviewed changes

source/features/edit-comments-faster.tsx Outdated Show resolved Hide resolved

rockwotj mentioned this pull request Oct 7, 2020

Add an auto assign button for reviewers #3624

Closed

fregante marked this pull request as draft October 7, 2020 21:57

fregante closed this Oct 7, 2020

fregante self-assigned this Oct 7, 2020

fregante reopened this Oct 7, 2020

fregante added 3 commits October 7, 2020 17:14

Merge remote-tracking branch 'origin/master' into pr/3407

2f25a23

Make selector more specific to avoid ?.

ed4ae02

Lint and comment

fb893fd

fregante removed their assignment Oct 7, 2020

fregante marked this pull request as ready for review October 7, 2020 22:30

fregante merged commit e1382b7 into refined-github:master Oct 7, 2020

fregante approved these changes Oct 7, 2020

View reviewed changes

source/features/edit-comments-faster.tsx Outdated Show resolved Hide resolved

kidonng deleted the edit-comments-faster branch October 8, 2020 00:39

nashbridges mentioned this pull request Oct 8, 2020

"Edit comment" button is only injected for a first post #3632

Closed

kidonng mentioned this pull request Oct 15, 2020

Disable edit-comments-faster on hidden comments #3651

Merged

kidonng added a commit to kidonng/refined-github that referenced this pull request Oct 15, 2020

Restore edit-comments-faster on review comments (refined-github#3407)

7a5ed69

Co-authored-by: Federico <me@fregante.com>

Uh oh!

Conversation

kidonng commented Jul 27, 2020 • edited by fregante Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of the lazy load logic mentioned in #3396

This PR

Uh oh!

Uh oh!

fregante commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidonng commented Jul 27, 2020

Uh oh!

fregante commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidonng commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidonng commented Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidonng commented Aug 28, 2020

Uh oh!

fregante commented Aug 28, 2020

Uh oh!

kidonng commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fregante left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kidonng commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🥳

Uh oh!

yakov116 commented Oct 12, 2020

Uh oh!

fregante commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

kidonng commented Jul 27, 2020 •

edited by fregante

Loading

fregante commented Jul 27, 2020 •

edited

Loading

fregante commented Jul 29, 2020 •

edited

Loading

kidonng commented Jul 29, 2020 •

edited

Loading

kidonng commented Aug 2, 2020 •

edited

Loading

kidonng commented Aug 28, 2020 •

edited

Loading

fregante left a comment •

edited

Loading

kidonng commented Oct 7, 2020 •

edited

Loading

fregante commented Oct 7, 2020 •

edited

Loading