Skip to content

Conversation

@kidonng
Copy link
Member

@kidonng kidonng commented Jul 27, 2020

Resolves #3403

Current screenshot:

image

Prototypes

image

image

I don't know how to name and describe this feature so suggestions welcome.

I feel like the dropdown caret on the "Add" button should not be dropped. And there's this download directory button added by us:

image

Wonder whether should take the text away.

@kidonng kidonng changed the title Add repo-icon-button feature Add repo-icon-buttons feature Jul 27, 2020
@kidonng kidonng marked this pull request as ready for review July 27, 2020 11:42
@kidonng
Copy link
Member Author

kidonng commented Jul 27, 2020

Just noticed there's a bug with grouping buttons (not the function itself) Fixed

@kidonng
Copy link
Member Author

kidonng commented Jul 27, 2020

Any idea on the feature name and description? And I really think we should drop the text in download-folder-button as well (maybe in another PR) because the inconsistency is confusing

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the removed button texts as tooltips?

@kidonng
Copy link
Member Author

kidonng commented Jul 27, 2020

@filipekiss Sorry please ignore this, wrong mention
@FloEdelmann Done

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
@kidonng
Copy link
Member Author

kidonng commented Jul 28, 2020

Should this works on isSingleFile as well?

@fregante fregante changed the title Add repo-icon-buttons feature Add cleanup-repo-filelist-actions feature Jul 29, 2020
@fregante fregante merged commit 5f9e771 into refined-github:master Jul 30, 2020
@kidonng
Copy link
Member Author

kidonng commented Jul 31, 2020

This feature frequently fails if you go from file tree/single file to repo root. I feel the need to use selector-observer or element-ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Make repo home buttons smaller

4 participants