Skip to content

Support branches with slashes in comments-time-machine-links#3404

Merged
fregante merged 6 commits intorefined-github:masterfrom
yakov116:time-line
Jul 30, 2020
Merged

Support branches with slashes in comments-time-machine-links#3404
fregante merged 6 commits intorefined-github:masterfrom
yakov116:time-line

Conversation

@yakov116
Copy link
Member

@yakov116 yakov116 commented Jul 26, 2020 •
edited by fregante
Loading

  1. LINKED ISSUES:
    Fixes comments-time-machine-links doesn't work with branches that have slashes #2901

  2. TEST URLS:

     https://github.com/Cog-Creators/Red-DiscordBot/blob/develop/cogs/downloader.py?rgh-link-date=2018-03-19T21%3A24%3A31Z

`

  1. SCREENSHOT:
    None

Gatcha:

	https://github.com/Cog-Creators/Red-DiscordBot/tree/V3/develop@%7B2019-09-07T19:14:39Z%7D?rgh-link-date=2020-06-02T18%3A02%3A49Z

Github URL does not drop the @%7B2019-09-07T19:14:39Z%7D from the branch name

fregante
fregante reviewed Jul 26, 2020
View reviewed changes
@fregante fregante added the bug label Jul 26, 2020
@yakov116
Copy link
Member Author

yakov116 commented Jul 26, 2020

@fregante off-topic:

I figured this out when I attempted #2927 (comment). Feels good to know my 2 hours of trying came to use ☕

@refined-github refined-github deleted a comment Jul 28, 2020
@fregante
Copy link
Member

fregante commented Jul 30, 2020 •
edited
Loading

This PR is supposed to fix bugs related to "branches with slashes" but it doesn't include a testing URL with "branches with slashes" that it's supposed to fix.

@fregante
Copy link
Member

fregante commented Jul 30, 2020 •
edited
Loading

Here's a link:

Raw:
https://github.com/Cog-Creators/Red-DiscordBot/blob/V3/develop/.gitignore

Pre-baked:
https://github.com/Cog-Creators/Red-DiscordBot/blob/V3/develop/.gitignore?rgh-link-date=2018-03-19T21%3A24%3A31Z

@fregante fregante changed the title Use API to get comments-time-machine-links sha Support branches with slashes in comments-time-machine-links Jul 30, 2020
@fregante fregante merged commit 33a1026 into refined-github:master Jul 30, 2020
@yakov116
Copy link
Member Author

yakov116 commented Jul 31, 2020

@fregante sorry that was a mistake. Will be more careful next time.

@yakov116 yakov116 deleted the time-line branch July 31, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante left review comments

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

comments-time-machine-links doesn't work with branches that have slashes

2 participants

@yakov116 @fregante