Skip to content

Make parse-backticks more reliable#3397

Merged
fregante merged 9 commits intorefined-github:masterfrom
kidonng:parse-backticks
Jul 27, 2020
Merged

Make parse-backticks more reliable#3397
fregante merged 9 commits intorefined-github:masterfrom
kidonng:parse-backticks

Conversation

@kidonng
Copy link
Member

@kidonng kidonng commented Jul 24, 2020 •
edited
Loading

On request by #3290 (comment)

Part of #3084

Edited the title and it stil runs well!!! 😋 (though there's about 2 seconds' delay) (Never mind, that is format-conversation-titles)

@kidonng kidonng changed the title Use selector-observer in parse-backticks Use selector-observer to run parse-backticks Jul 24, 2020
fregante
fregante reviewed Jul 24, 2020
View reviewed changes
@kidonng
Copy link
Member Author

kidonng commented Jul 24, 2020

We have to test the selectors and narrow scope down since they are now global

@kidonng
Copy link
Member Author

kidonng commented Jul 24, 2020

  • Grouped/merged related selectors
  • Replace some generic selectors with more specific selectors
  • Add detailed comments

fregante
fregante reviewed Jul 24, 2020
View reviewed changes
@yakov116
Copy link
Member

yakov116 commented Jul 26, 2020

Not sure if you fixed this but

image

@kidonng
Copy link
Member Author

kidonng commented Jul 26, 2020 •
edited
Loading

Yeah it's parsed

image

Isn't the selector for that place is already included before this PR? https://github.com/sindresorhus/refined-github/pull/3397/files#diff-7b0a2c8650978a85cebddd08a46e40baL29

@yakov116
Copy link
Member

yakov116 commented Jul 26, 2020

Funny it was not working for me before

fregante
fregante approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work correctly so far. I'll be testing this more

@yakov116
Copy link
Member

yakov116 commented Jul 26, 2020

Should we make a line break in between each unique page type? (Ex: isWiki isDashboard) I think it will make it a drop easier to read.

@fregante
Copy link
Member

fregante commented Jul 26, 2020

I don't think there's any way to make it any more readable. It's a list of wildly different selectors, it's just what it is

@fregante fregante added bug and removed enhancement labels Jul 27, 2020
@fregante fregante changed the title Use selector-observer to run parse-backticks Make parse-backticks more reliable Jul 27, 2020
@fregante fregante changed the title Make parse-backticks more reliable Make parse-backticks more reliable / test Jul 27, 2020
@fregante fregante changed the title Make parse-backticks more reliable / test Make parse-backticks more reliable Jul 27, 2020
@fregante fregante merged commit 25ce509 into refined-github:master Jul 27, 2020
@fregante
Copy link
Member

fregante commented Jul 27, 2020

Looks great! Possible additions:

@yakov116
Copy link
Member

yakov116 commented Jul 28, 2020

This is awesome!! https://github.com/tanmayrajani/notifications-preview-github is now parsed too!!

@kidonng
Copy link
Member Author

kidonng commented Jul 28, 2020

Is it https://github.com/sindresorhus/refined-github/pull/3397/files#diff-7b0a2c8650978a85cebddd08a46e40baR31? I don't have the extension

@yakov116
Copy link
Member

yakov116 commented Jul 28, 2020

Yes.

You should get it, its an awesome extension.

@kidonng kidonng deleted the parse-backticks branch July 28, 2020 02:59
@kidonng kidonng mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kidonng @yakov116 @fregante