Skip to content

Conversation

@kidonng
Copy link
Member

@kidonng kidonng commented Jul 16, 2020

From #3353 (comment)

Before:

After:

@fregante
Copy link
Member

The smaller size was on purpose

@kidonng
Copy link
Member Author

kidonng commented Jul 17, 2020

This class exists (or more precisely, is added) in the feature's first commit (https://github.com/sindresorhus/refined-github/pull/1049/files#diff-041e2c7f28122df0efbf5dbb6ee3c2adR22), in which I don't see any reason except matching GitHub's style.

@fregante
Copy link
Member

#3221 by @FloEdelmann, in the very first post

@kidonng
Copy link
Member Author

kidonng commented Jul 17, 2020

Missed that one. But that PR is made when design update is in progress, do you still think it looks fine with different button size?

image
image

image
image

@fregante
Copy link
Member

do you still think it looks fine with different button size?

I do; you can see how the buttons also become wider and the space on that line might be limited already

@kidonng
Copy link
Member Author

kidonng commented Jul 17, 2020

Adjust the size with the following style:

.rgh-latest-tag-button,
.rgh-latest-tag-button + .btn,
.js-permalink-shortcut + div .btn-sm[data-pjax] {
    padding: 4px 16px 5px;
    font-size: 14px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants