Skip to content

Fix latest-tag-button #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 1 commit into from
Jul 16, 2020
Merged

Fix latest-tag-button #3353

fregante merged 1 commit into from
Jul 16, 2020

Conversation

@kidonng
Copy link
Member

@kidonng kidonng commented Jul 16, 2020

Fix #3277 (comment)

This is a placeholder, once the feature goes into production (likely) we can fix it (or make other changes).

Screenshot with the fix:
image

@fregante fregante marked this pull request as ready for review July 16, 2020 08:45
@fregante
Copy link
Member

fregante commented Jul 16, 2020

I don't think we need to wait for that. The branch selector already exists on both versions.

I blamed the line and there doesn't seem to be a specific reason why it used .breadcrumb in the first place

@fregante fregante added the bug label Jul 16, 2020
@fregante fregante merged commit 9975528 into refined-github:master Jul 16, 2020
@kidonng
Copy link
Member Author

kidonng commented Jul 16, 2020 •
edited
Loading

Well, let's remove .btn-sm at least before merging? 😂

image

@kidonng kidonng mentioned this pull request Jul 16, 2020
Closed
@kidonng kidonng deleted the latest-tag-button branch July 28, 2020 02:58
@kidonng
Copy link
Member Author

kidonng commented Aug 24, 2020 •
edited
Loading

I blamed the line and there doesn't seem to be a specific reason why it used .breadcrumb in the first place

Possibly because of this

https://github.com/sindresorhus/refined-github/blob/79a8166955f56ca9185ec9f8db2d56da0d2b304f/source/features/list-prs-for-file.tsx#L133

EDIT: 9dd3255#diff-17e888e0cbbb7ff31a50ae3c52bb74a8R94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show latest commit message on project page

2 participants

@kidonng @fregante