Lint and avoid errors #3314

yakov116 · 2020-07-03T14:13:43Z

Yeah that time of week LOL

Fix releases-tab again. Not all repositories have it on the side bar, yet they all have it on the main bar.
Exclude pr file 404 from pr-jump-to-first-non-viewed-file
Fix projects not available of clean-sidebar fixes clean-sidebar: can't access property "nextElementSibling", header is null #3134
Fix min width Options page in Edge Chromium fixes Options page in Edge Chromium has fixed width #3312
Fix missing open on desktop fixes Clone or Download > Open in Desktop button is missing #3307
Fix "comment required" detection in quick-review-buttons fixes Review requires comment even with pending comment(s) #3309
Restore hide-watch-and-fork-count border Match border radius in GitHub new design #3247 (comment)
reaction-avatars Use css class instead of inline style Match border radius in GitHub new design #3247 (review)
Run align-issue-labels only on isConversationList

source/features/pr-jump-to-first-non-viewed-file.tsx

yakov116 · 2020-07-03T14:27:49Z

Was going to do

It might be worth deleting getRepoURL and adding it to this line https://github.com/sindresorhus/refined-github/blob/daf633137ec08e6f5647a6f8bb0b02d5dce58ef9/source/github-helpers/index.ts#L8

Originally posted by @fregante in #3308 (comment)

But dont this we gain anything since

We have to make it lowercase though, to not undo #2892.

Originally posted by @FloEdelmann in #3308 (comment)

Co-Authored-By: Fregante <opensource@bfred.it>

yakov116 · 2020-07-03T19:12:06Z

https://github.com/sindresorhus/refined-github/blob/0fa514dbeeab6395ef095cff80beac41443a6574/source/features/copy-on-y.tsx#L8

@fregante can this be changed to isEditable?

fregante · 2020-07-03T23:53:59Z

Yes

source/features/quick-review-buttons.tsx

source/options.css

kidonng · 2020-07-05T01:40:52Z

@yakov116 Could you also add #3247 (comment) and https://github.com/sindresorhus/refined-github/pull/3247/files/dd15d83e6f55d7be29c528535479246aaf1c27f7#diff-c372438f929b897327158a989ea88c17R65 (change current style to className)?

source/features/esc-to-deselect-line.tsx

fregante · 2020-07-05T14:34:32Z

Regarding reaction-avatars: GitHub has a native component for that, it’s called “avatar stack” and we could use it to drop some of our custom CSS. It can be found on the dashboard.

However that should probably be its own PR because I don’t know if it works as well as ours

yakov116 · 2020-07-05T14:38:23Z

I think I'm done here. 😄

kidonng · 2020-07-05T14:50:05Z

source/features/reactions-avatars.tsx

 			// Without this, Firefox will follow the link instead of submitting the reaction button
 			<a href={isFirefox ? undefined : `/${username}`} className="rounded-1 avatar-user">
-				<img src={imageUrl} style={{borderRadius: 'inherit'}}/>
+				<img src={imageUrl} className="rounded-1"/>


You should use className="avatar-user rounded-1" because rounded-1 is for old design and has smaller radius (6px):

Suggested change

<img src={imageUrl} className="rounded-1"/>

<img src={imageUrl} className="avatar-user rounded-1"/>

@yakov116 Why?

Followed @kidonng #3314 (comment)

You should use className="avatar-user rounded-1" because rounded-1 is for old design and has smaller radius (6px):

Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com> You should use className="avatar-user rounded-1" because rounded-1 is for old design and has smaller radius (6px):

source/features/esc-to-deselect-line.tsx

Co-authored-by: Fregante <opensource@bfred.it>

source/options.css

source/features/pr-jump-to-first-non-viewed-file.tsx

kidonng · 2020-07-06T12:08:29Z

Could you please revert another mistake in #3247 (comment) again 😅? (and you should use 6px now)

source/features/minimize-upload-bar.css

Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com>

source/features/pr-jump-to-first-non-viewed-file.tsx

yakov116 · 2020-07-07T21:35:11Z

@fregante anything waiting on me to finish?

yakov116 · 2020-07-07T22:39:48Z

@fregante did you get the new preview? If yes from what i see we now have an issue detecting permalinks from the branch selector. It does not say if its a tag/tree anymore.

fregante · 2020-07-07T22:40:36Z

Let's handle that in a separate PR once that design leaves beta.

fregante · 2020-07-07T22:44:22Z

In your next round you could change this line to use github-url-detection https://github.com/sindresorhus/refined-github/blob/da8313019d31ab4bdf3fd4a5f75be961d95a6a9a/source/features/file-finder-buffer.tsx#L18

yakov116 · 2020-07-07T23:07:07Z

In your next round you could change this line to use github-url-detection

Next round?? Why would there be that? Lol

yakov116 · 2020-07-08T00:24:39Z

source/features/align-issue-labels.tsx

@@ -12,5 +14,8 @@ void features.add({
 }, {
 	waitForDomReady: false,
 	repeatOnAjax: false,


any reason this is not working correctly with repeatOnAjax: false

Because sometimes it goes from isPR to isConversationList with an ajax load, but repeatOnAjax: false prevents the page detection, it should be dropped

yakov116 added 2 commits July 3, 2020 10:05

Fix releases-tab again

3e9e3a4

Exclude isPRCommit404 from pr-jump-to-first-non-viewed-file

677173f

yakov116 commented Jul 3, 2020

View reviewed changes

source/features/pr-jump-to-first-non-viewed-file.tsx Outdated Show resolved Hide resolved

yakov116 and others added 2 commits July 3, 2020 10:47

Don't break clean-sidebar if container does not exist

68ca8fb

Fix min width Options page in Edge Chromium

a27a069

Co-Authored-By: Fregante <opensource@bfred.it>

yakov116 mentioned this pull request Jul 3, 2020

Options page in Edge Chromium has fixed width #3312

Closed

yakov116 added 4 commits July 3, 2020 11:28

Lint

2008dad

Exclude it better

8a542ed

Fix open on desktop selector

4524fbc

Fix "comment required" detection in quick-review-buttons

c158dcf

fregante reviewed Jul 3, 2020

View reviewed changes

source/features/quick-review-buttons.tsx Outdated Show resolved Hide resolved

source/options.css Outdated Show resolved Hide resolved

yakov116 added 6 commits July 5, 2020 07:41

pending comments

2888b86

Run align-issue-labels only on isConversationList

959aa86

Fix comment position

5f0d81f

isEditable

bce86bd

Restore hide-watch-and-fork-count border

10921db

reaction-avatars Use css class instead of inline style

a2cef84

yakov116 commented Jul 5, 2020

View reviewed changes

source/features/esc-to-deselect-line.tsx Outdated Show resolved Hide resolved

Drop the comments

e6499d4

yakov116 marked this pull request as ready for review July 5, 2020 14:37

kidonng requested changes Jul 5, 2020

View reviewed changes

Update selectors.tsx

24eb7f6

Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com> You should use className="avatar-user rounded-1" because rounded-1 is for old design and has smaller radius (6px):

fregante added the bug label Jul 5, 2020

fregante reviewed Jul 5, 2020

View reviewed changes

source/features/esc-to-deselect-line.tsx Outdated Show resolved Hide resolved

Fix mistaken tab

c8a1b40

Co-authored-by: Fregante <opensource@bfred.it>

fregante reviewed Jul 5, 2020

View reviewed changes

source/options.css Show resolved Hide resolved

fregante reviewed Jul 5, 2020

View reviewed changes

source/features/pr-jump-to-first-non-viewed-file.tsx Show resolved Hide resolved

yakov116 mentioned this pull request Jul 5, 2020

Add isPRFile404 refined-github/github-url-detection#20

Merged

Merge remote-tracking branch 'upstream/master' into lint-console

bd509b1

yakov116 added 2 commits July 6, 2020 09:07

Merge remote-tracking branch 'upstream/master' into lint-console

d864a03

minimize-upload-bar add back border-radius

50a1e86

kidonng reviewed Jul 6, 2020

View reviewed changes

source/features/minimize-upload-bar.css Outdated Show resolved Hide resolved

Update source/features/minimize-upload-bar.css

09e7b7f

Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com>

yakov116 commented Jul 7, 2020

View reviewed changes

source/features/pr-jump-to-first-non-viewed-file.tsx Outdated Show resolved Hide resolved

yakov116 added 2 commits July 7, 2020 17:02

isPRFile404

df11b5b

Update github-url-detection

30f178b

fregante merged commit da83130 into refined-github:master Jul 7, 2020

yakov116 deleted the lint-console branch July 7, 2020 23:07

yakov116 commented Jul 8, 2020

View reviewed changes

fregante mentioned this pull request Aug 11, 2020

Replace repeatOnAjax with explicit onetime #3442

Merged

	<img src={imageUrl} className="rounded-1"/>
	<img src={imageUrl} className="avatar-user rounded-1"/>

Uh oh!

Lint and avoid errors #3314

Lint and avoid errors #3314

Uh oh!

Conversation

yakov116 commented Jul 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yakov116 commented Jul 3, 2020

Uh oh!

yakov116 commented Jul 3, 2020

Uh oh!

fregante commented Jul 3, 2020

Uh oh!

Uh oh!

Uh oh!

kidonng commented Jul 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fregante commented Jul 5, 2020

Uh oh!

yakov116 commented Jul 5, 2020

Uh oh!

kidonng Jul 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yakov116 Jul 5, 2020

Choose a reason for hiding this comment

Uh oh!

fregante Jul 5, 2020

Choose a reason for hiding this comment

Uh oh!

yakov116 Jul 5, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kidonng commented Jul 6, 2020

Uh oh!

Uh oh!

Uh oh!

yakov116 commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yakov116 commented Jul 7, 2020

Uh oh!

fregante commented Jul 7, 2020

Uh oh!

fregante commented Jul 7, 2020

Uh oh!

yakov116 commented Jul 7, 2020

Uh oh!

yakov116 Jul 8, 2020

Choose a reason for hiding this comment

Uh oh!

fregante Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

yakov116 commented Jul 3, 2020 •

edited

Loading

kidonng commented Jul 5, 2020 •

edited

Loading

kidonng Jul 5, 2020 •

edited

Loading

yakov116 commented Jul 7, 2020 •

edited

Loading

fregante Jul 13, 2020 •

edited

Loading