Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"fit-textarea": "^2.0.0",
"flat-zip": "^1.0.1",
"github-reserved-names": "^1.1.8",
"github-url-detection": "^1.2.3",
"github-url-detection": "^2.0.0",
"image-promise": "^7.0.1",
"indent-textarea": "^2.0.1",
"linkify-issues": "2.0.0-nolookbehind",
Expand Down
30 changes: 15 additions & 15 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,28 +195,28 @@ Thanks for contributing! 🦋🙌
- [](# "scrollable-code-and-blockquote") [Limits the height of tall code blocks and quotes.](https://github.com/sindresorhus/refined-github/issues/1123)
- [](# "hide-comments-faster") [Simplifies the UI to hide comments.](https://user-images.githubusercontent.com/1402241/43039221-1ddc91f6-8d29-11e8-9ed4-93459191a510.gif)
- [](# "open-issue-to-latest-comment") [Makes the "comment" icon in issue lists link to the latest comment of the issue.](https://user-images.githubusercontent.com/14323370/57962709-7019de00-78e8-11e9-8398-7e617ba7a96f.png)
- [](# "expand-all-hidden-comments") [On long discussions where GitHub hides comments under a "Load more...", alt-clicking it will load up to 200 comments at once instead of 60.](https://user-images.githubusercontent.com/1402241/73838332-0c548e00-4846-11ea-935f-28d728b30ae9.png)
- [](# "expand-all-hidden-comments") [On long conversations where GitHub hides comments under a "Load more...", alt-clicking it will load up to 200 comments at once instead of 60.](https://user-images.githubusercontent.com/1402241/73838332-0c548e00-4846-11ea-935f-28d728b30ae9.png)

<!-- Refer to style guide above. Keep this message between sections. -->

### Discussions
### Conversations

- [](# "batch-open-issues") 🔥 [Adds a button to open multiple discussions at once in your repos.](https://user-images.githubusercontent.com/1402241/38084752-4820b0d8-3378-11e8-868c-a1582b16f915.gif)
- [](# "batch-open-conversations") 🔥 [Adds a button to open multiple conversations at once in your repos.](https://user-images.githubusercontent.com/1402241/38084752-4820b0d8-3378-11e8-868c-a1582b16f915.gif)
- [](# "split-issue-pr-search-results") [Separates issues from PRs in the global search.](https://user-images.githubusercontent.com/1402241/52181103-35a09f80-2829-11e9-9c6f-57f2e08fc5b2.png)
- [](# "sticky-discussion-sidebar") [Makes the discussion sidebar sticky.](https://user-images.githubusercontent.com/10238474/62276723-5a2eaa80-b44d-11e9-810b-ff598d1c5c6a.gif)
- [](# "sticky-discussion-list-toolbar") [Makes the discussion list’s filters toolbar sticky.](https://user-images.githubusercontent.com/380914/39878141-7632e61a-542c-11e8-9c66-74fcd3a134aa.gif)
- [](# "highlight-collaborators-and-own-discussions") [Highlights discussions opened by you or the current repo’s collaborators.](https://user-images.githubusercontent.com/1402241/65013882-03225d80-d947-11e9-8eb8-5507bc1fc14b.png)
- [](# "sticky-conversation-sidebar") [Makes the conversation sidebar sticky.](https://user-images.githubusercontent.com/10238474/62276723-5a2eaa80-b44d-11e9-810b-ff598d1c5c6a.gif)
- [](# "sticky-conversation-list-toolbar") [Makes the conversation list’s filters toolbar sticky.](https://user-images.githubusercontent.com/380914/39878141-7632e61a-542c-11e8-9c66-74fcd3a134aa.gif)
- [](# "highlight-collaborators-and-own-conversations") [Highlights conversations opened by you or the current repo’s collaborators.](https://user-images.githubusercontent.com/1402241/65013882-03225d80-d947-11e9-8eb8-5507bc1fc14b.png)
- [](# "align-issue-labels") [Aligns labels in lists to the left.](https://user-images.githubusercontent.com/1402241/28006237-070b8214-6581-11e7-94bc-2b01a007d00b.png)
- [](# "sort-issues-by-update-time") 🔥 Changes the default sort order of discussions to `Recently updated`.
- [](# "widen-search-field") [Widens the discussion search box.](https://user-images.githubusercontent.com/1402241/55069759-bceaf080-50bf-11e9-84d0-7707de2eb9e9.png)
- [](# "discussion-filters") [Adds `Everything commented by you` and `Everything you subscribed to` filters in the search box dropdown.](https://user-images.githubusercontent.com/202916/84156153-72a62300-aa69-11ea-8592-3094292fde3c.png)
- [](# "global-discussion-list-filters") [Adds filters for discussions _in your repos_ and _commented on by you_ in the global discussion search.](https://user-images.githubusercontent.com/8295888/36827126-8bfc79c4-1d37-11e8-8754-992968b082be.png)
- [](# "clean-sidebar") 🔥 [Hides empty sections (or just their "empty" label) in the discussion sidebar.](https://user-images.githubusercontent.com/1402241/57199809-20691780-6fb6-11e9-9672-1ad3f9e1b827.png)
- [](# "clean-issue-filters") [Hides `Projects` and `Milestones` filters in discussion lists if they are empty.](https://user-images.githubusercontent.com/37769974/59083449-0ef88f80-8915-11e9-8296-68af1ddcf191.png)
- [](# "sort-conversations-by-update-time") 🔥 Changes the default sort order of conversations to `Recently updated`.
- [](# "widen-search-field") [Widens the conversation search box.](https://user-images.githubusercontent.com/1402241/55069759-bceaf080-50bf-11e9-84d0-7707de2eb9e9.png)
- [](# "conversation-filters") [Adds `Everything commented by you` and `Everything you subscribed to` filters in the search box dropdown.](https://user-images.githubusercontent.com/202916/84156153-72a62300-aa69-11ea-8592-3094292fde3c.png)
- [](# "global-conversation-list-filters") [Adds filters for conversations _in your repos_ and _commented on by you_ in the global conversation search.](https://user-images.githubusercontent.com/8295888/36827126-8bfc79c4-1d37-11e8-8754-992968b082be.png)
- [](# "clean-sidebar") 🔥 [Hides empty sections (or just their "empty" label) in the conversation sidebar.](https://user-images.githubusercontent.com/1402241/57199809-20691780-6fb6-11e9-9672-1ad3f9e1b827.png)
- [](# "clean-conversation-filters") [Hides `Projects` and `Milestones` filters in conversation lists if they are empty.](https://user-images.githubusercontent.com/37769974/59083449-0ef88f80-8915-11e9-8296-68af1ddcf191.png)
- [](# "cycle-lists-with-keyboard-shortcuts") [Allows the <kbd>↑</kbd> and <kbd>↓</kbd> keys to cycle "popover lists" (labels, milestones, etc).](https://user-images.githubusercontent.com/37769974/59158786-6fd2c400-8add-11e9-9db1-db80186fa6ea.gif)
- [](# "toggle-everything-with-alt") [Adds a shortcut to toggle all similar items (minimized comments, deferred diffs, etc) at once: <kbd>alt</kbd> <kbd>click</kbd> on each button or checkbox.](https://user-images.githubusercontent.com/37769974/62208543-dcb75b80-b3b4-11e9-984f-ddb479ea149d.gif)
- [](# "quick-mention") [Adds a button to `@mention` a user in discussions.](https://user-images.githubusercontent.com/1402241/70406615-f445d580-1a73-11ea-9ab1-bf6bd9aa70a3.gif)
- [](# "extend-discussion-status-filters") [Lets you toggle between is:open/is:closed/is:merged filters in searches.](https://user-images.githubusercontent.com/1402241/73605061-2125ed00-45cc-11ea-8cbd-41a53ae00cd3.gif)
- [](# "quick-mention") [Adds a button to `@mention` a user in conversations.](https://user-images.githubusercontent.com/1402241/70406615-f445d580-1a73-11ea-9ab1-bf6bd9aa70a3.gif)
- [](# "extend-conversation-status-filters") [Lets you toggle between is:open/is:closed/is:merged filters in searches.](https://user-images.githubusercontent.com/1402241/73605061-2125ed00-45cc-11ea-8cbd-41a53ae00cd3.gif)
- [](# "bugs-tab") [Adds a "Bugs" tab to repos, if there are any open issues with the "bug" label.](https://user-images.githubusercontent.com/1402241/73720910-a688d900-4755-11ea-9c8d-70e5ddb3bfe5.png)
- [](# "pinned-issue-update-time") [Adds the updated time to pinned issues.](https://user-images.githubusercontent.com/1402241/75525936-bb524700-5a4b-11ea-9225-466bda58b7de.png)
- [](# "clean-pinned-issues") [Changes the layout of pinned issues from side-by-side to a standard list.](https://user-images.githubusercontent.com/1402241/84509958-c82a3c00-acc4-11ea-8399-eaf06a59e9e4.png)
Expand Down Expand Up @@ -290,7 +290,7 @@ Thanks for contributing! 🦋🙌
- [](# "linkify-user-location") [Linkifies the user location in their hovercard and profile page.](https://user-images.githubusercontent.com/1402241/69076885-00d3a100-0a67-11ea-952a-690acec0826f.png)
- [](# "user-local-time") [Shows the user local time in their hovercard (based on their last commit).](https://user-images.githubusercontent.com/1402241/69863648-ef449180-12cf-11ea-8f36-7c92fc487f31.gif)
- [](# "hide-zero-packages") [Hides the `Packages` tab on user profiles if it’s empty.](https://user-images.githubusercontent.com/35382021/62426530-688ef780-b6d5-11e9-93f2-515110aed1eb.jpg)
- [](# "discussion-links-on-repo-lists") [Adds a link to the issues and pulls on the user profile repository tab and global search.](https://user-images.githubusercontent.com/16872793/78712349-82c54900-78e6-11ea-8328-3c2d39a78862.png)
- [](# "conversation-links-on-repo-lists") [Adds a link to the issues and pulls on the user profile repository tab and global search.](https://user-images.githubusercontent.com/16872793/78712349-82c54900-78e6-11ea-8328-3c2d39a78862.png)

<!-- Refer to style guide above. Keep this message between sections. -->

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function getUrlFromItem(checkbox: Element): string {
}

function openIssues(): void {
const modifier = pageDetect.isGlobalDiscussionList() ? '' : ' + div ';
const modifier = pageDetect.isGlobalConversationList() ? '' : ' + div ';
const issues = select.all([
`#js-issues-toolbar.triage-mode ${modifier} [name="issues[]"]:checked`, // Get checked checkboxes
`#js-issues-toolbar:not(.triage-mode) ${modifier} .js-issue-row` // Or all items
Expand All @@ -41,7 +41,7 @@ async function init(): Promise<void | false> {

delegate(document, '.rgh-batch-open-issues', 'click', openIssues);

// Add button to open all visible discussions
// Add button to open all visible conversations
select('.table-list-header-toggle:not(.states)')?.prepend(
<button
type="button"
Expand All @@ -51,7 +51,7 @@ async function init(): Promise<void | false> {
</button>
);

// Add button to open selected discussions
// Add button to open selected conversations
const triageFiltersBar = select('.table-list-triage > .text-gray');
if (triageFiltersBar) {
triageFiltersBar.classList.add('table-list-header-toggle'); // Handles link :hover style
Expand All @@ -68,11 +68,11 @@ async function init(): Promise<void | false> {

void features.add({
id: __filebasename,
description: 'Adds a button to open multiple discussions at once in your repos.',
description: 'Adds a button to open multiple conversations at once in your repos.',
screenshot: 'https://user-images.githubusercontent.com/1402241/38084752-4820b0d8-3378-11e8-868c-a1582b16f915.gif'
}, {
include: [
pageDetect.isDiscussionList
pageDetect.isConversationList
],
waitForDomReady: false,
init
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ async function init(): Promise<void | false> {

void features.add({
id: __filebasename,
description: 'Hides `Projects` and `Milestones` filters in discussion lists if they are empty.',
description: 'Hides `Projects` and `Milestones` filters in conversation lists if they are empty.',
screenshot: 'https://user-images.githubusercontent.com/37769974/59083449-0ef88f80-8915-11e9-8296-68af1ddcf191.png'
}, {
include: [
pageDetect.isRepoDiscussionList
pageDetect.isRepoConversationList
],
waitForDomReady: false,
init
Expand Down
6 changes: 3 additions & 3 deletions source/features/clean-notifications.css
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
/* Place discussion number before the title */
/* Place conversation number before the title */
.js-notifications-group [id^='notification'] {
flex-direction: row !important;
}
/* Hide duplicate repository URL */
.js-notifications-group [id^='notification'] > .d-flex > .f6 {
font-size: 0 !important;
}
/* Size and position the discussion number */
/* Size and position the conversation number */
.js-notifications-group [id^='notification'] > .d-flex > .f6 > span {
display: block;
font-size: 12px;
font-variant-numeric: tabular-nums;
margin-top: 2px; /* Align baseline with discussion title */
margin-top: 2px; /* Align baseline with conversation title */
margin-right: 8px;
word-break: keep-all;
}
2 changes: 1 addition & 1 deletion source/features/clean-sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ async function clean(): Promise<void> {

void features.add({
id: __filebasename,
description: 'Hides empty sections (or just their "empty" label) in the discussion sidebar.',
description: 'Hides empty sections (or just their "empty" label) in the conversation sidebar.',
screenshot: 'https://user-images.githubusercontent.com/1402241/57199809-20691780-6fb6-11e9-9672-1ad3f9e1b827.png'
}, {
include: [
Expand Down
2 changes: 1 addition & 1 deletion source/features/conflict-marker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void features.add({
'https://user-images.githubusercontent.com/9092510/62777551-2affe500-baae-11e9-8ba4-67f078347913.png'
}, {
include: [
pageDetect.isDiscussionList
pageDetect.isConversationList
],
init
});
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void features.add({
screenshot: 'https://user-images.githubusercontent.com/202916/84156153-72a62300-aa69-11ea-8592-3094292fde3c.png'
}, {
include: [
pageDetect.isRepoDiscussionList
pageDetect.isRepoConversationList
],
init
});
2 changes: 1 addition & 1 deletion source/features/dim-bots.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void features.add({
}, {
include: [
pageDetect.isCommitList,
pageDetect.isDiscussionList
pageDetect.isConversationList
],
init
});
2 changes: 1 addition & 1 deletion source/features/expand-all-hidden-comments.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function init(): void {

void features.add({
id: __filebasename,
description: 'On long discussions where GitHub hides comments under a "Load more...", alt-clicking it will load up to 200 comments at once instead of 60.',
description: 'On long conversations where GitHub hides comments under a "Load more...", alt-clicking it will load up to 200 comments at once instead of 60.',
screenshot: 'https://user-images.githubusercontent.com/1402241/73838332-0c548e00-4846-11ea-935f-28d728b30ae9.png'
}, {
include: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ void features.add({
screenshot: 'https://user-images.githubusercontent.com/1402241/73605061-2125ed00-45cc-11ea-8cbd-41a53ae00cd3.gif'
}, {
include: [
pageDetect.isDiscussionList
pageDetect.isConversationList
],
waitForDomReady: false,
init
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import './global-discussion-list-filters.css';
import './global-conversation-list-filters.css';
import React from 'dom-chef';
import select from 'select-dom';
import * as pageDetect from 'github-url-detection';
Expand Down Expand Up @@ -44,11 +44,11 @@ function init(): void {

void features.add({
id: __filebasename,
description: 'Adds filters for discussions _in your repos_ and _commented on by you_ in the global discussion search.',
description: 'Adds filters for conversations _in your repos_ and _commented on by you_ in the global conversation search.',
screenshot: 'https://user-images.githubusercontent.com/8295888/36827126-8bfc79c4-1d37-11e8-8754-992968b082be.png'
}, {
include: [
pageDetect.isGlobalDiscussionList
pageDetect.isGlobalConversationList
],
init
});
2 changes: 1 addition & 1 deletion source/features/hide-issue-list-autocomplete.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ void features.add({
screenshot: 'https://user-images.githubusercontent.com/1402241/42991841-1f057e4e-8c07-11e8-909c-b051db7a2a03.png'
}, {
include: [
pageDetect.isDiscussionList
pageDetect.isConversationList
],
init
});
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import './highlight-collaborators-and-own-discussions.css';
import './highlight-collaborators-and-own-conversations.css';
import cache from 'webext-storage-cache';
import select from 'select-dom';
import * as pageDetect from 'github-url-detection';
Expand Down Expand Up @@ -43,16 +43,16 @@ function highlightSelf(): void {

void features.add({
id: __filebasename,
description: 'Highlights discussions opened by you or the current repo’s collaborators.',
description: 'Highlights conversations opened by you or the current repo’s collaborators.',
screenshot: 'https://user-images.githubusercontent.com/1402241/65013882-03225d80-d947-11e9-8eb8-5507bc1fc14b.png'
}, {
include: [
pageDetect.isRepoDiscussionList
pageDetect.isRepoConversationList
],
init: highlightCollaborators
}, {
include: [
pageDetect.isDiscussionList
pageDetect.isConversationList
],
init: highlightSelf
});
2 changes: 1 addition & 1 deletion source/features/open-issue-to-latest-comment.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ void features.add({
screenshot: 'https://user-images.githubusercontent.com/14323370/57962709-7019de00-78e8-11e9-8398-7e617ba7a96f.png'
}, {
include: [
pageDetect.isDiscussionList
pageDetect.isConversationList
],
init
}, {
Expand Down
4 changes: 2 additions & 2 deletions source/features/parse-backticks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function init(): void {
'.commit-message', // Pushed commits in `isPRConversation`, `isCompare`, `isReleasesOrTags`
'.message', // `isCommitList`, `isRepoTree`, `isBlame`
'.Box--condensed .link-gray[href*="/commit/"]', // `isSingleFile`
'[aria-label="Issues"][role="group"] .js-navigation-open', // `isDiscussionList`
'[aria-label="Issues"][role="group"] .js-navigation-open', // `isConversationList`
'[id^=ref-issue-]', // Issue references in `isIssue`, `isPRConversation`
'[id^=ref-pullrequest-]', // PR references in `isIssue`, `isPRConversation`
'.TimelineItem-body > del, .TimelineItem-body > ins', // Title edits in `isIssue`, `isPRConversation`
Expand All @@ -22,7 +22,7 @@ function init(): void {
'.js-recent-activity-container .text-bold', // `isDashboard`"Recent activity" titles
'.commits blockquote', // Newsfeed commits
'.release-header', // `isReleasesOrTags` Headers
'.Box-row.js-navigation-item a.link-gray-dark', // `isGlobalDiscussionList`
'.Box-row.js-navigation-item a.link-gray-dark', // `isGlobalConversationList`
'[data-channel^="check_suites"] a', // `isActions`
'.repository-content .pr-toolbar h2', // `isActions` run
'#wiki-wrapper h1' // `isWiki`
Expand Down
2 changes: 1 addition & 1 deletion source/features/pr-branches.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ void features.add({
screenshot: 'https://user-images.githubusercontent.com/1402241/51428391-ae9ed500-1c35-11e9-8e54-6b6a424fede4.png'
}, {
include: [
pageDetect.isRepoDiscussionList
pageDetect.isRepoConversationList
],
init
});
4 changes: 2 additions & 2 deletions source/features/quick-mention.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ function init(): void {

void features.add({
id: __filebasename,
description: 'Adds a button to @mention a user in discussions.',
description: 'Adds a button to @mention a user in conversations.',
screenshot: 'https://user-images.githubusercontent.com/1402241/70406615-f445d580-1a73-11ea-9ab1-bf6bd9aa70a3.gif'
}, {
include: [
pageDetect.isIssue,
pageDetect.isPRConversation
],
exclude: [
() => select.exists('.conversation-limited') // Discussion is locked
() => select.exists('.conversation-limited') // Conversation is locked
],
additionalListeners: [
onNewComments
Expand Down
2 changes: 1 addition & 1 deletion source/features/repo-wide-file-finder.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ void features.add({
screenshot: false
}, {
include: [
pageDetect.isRepoDiscussionList,
pageDetect.isRepoConversationList,
pageDetect.isPR,
pageDetect.isIssue
],
Expand Down
4 changes: 2 additions & 2 deletions source/features/restore-file.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import features from '.';
import * as api from '../github-helpers/api';
import fetchDom from '../helpers/fetch-dom';
import postForm from '../helpers/post-form';
import {getDiscussionNumber, getRepoGQL, getRepoURL, getCurrentBranch} from '../github-helpers';
import {getConversationNumber, getRepoGQL, getRepoURL, getCurrentBranch} from '../github-helpers';

function showError(menuItem: HTMLButtonElement, error: string): void {
menuItem.disabled = true;
Expand All @@ -23,7 +23,7 @@ This value is not consistently available on the page (appears in `/files` but no
const getBaseReference = onetime(async (): Promise<string> => {
const {repository} = await api.v4(`
repository(${getRepoGQL()}) {
pullRequest(number: ${getDiscussionNumber()!}) {
pullRequest(number: ${getConversationNumber()!}) {
baseRefOid
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ function init(): void {

void features.add({
id: __filebasename,
description: 'Changes the default sort order of discussions to `Recently updated`.',
description: 'Changes the default sort order of conversations to `Recently updated`.',
screenshot: false
}, {
init
}, {
include: [
pageDetect.isGlobalDiscussionList
pageDetect.isGlobalConversationList
],
waitForDomReady: false,
repeatOnAjax: false,
Expand Down
Loading