Skip to content

Rename discussion → conversation #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 5 commits into from
Jul 2, 2020
Merged

Rename discussion → conversation #3308

fregante merged 5 commits into from
Jul 2, 2020

Conversation

@FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented Jul 1, 2020

@FloEdelmann FloEdelmann mentioned this pull request Jul 1, 2020
Merged
@fregante
Copy link
Member

fregante commented Jul 1, 2020

Awesome!

@fregante fregante merged commit daf6331 into refined-github:master Jul 2, 2020
@fregante
Copy link
Member

fregante commented Jul 2, 2020

It might be worth deleting getRepoURL and adding it to this line https://github.com/sindresorhus/refined-github/blob/daf633137ec08e6f5647a6f8bb0b02d5dce58ef9/source/github-helpers/index.ts#L8

@fregante fregante added the meta Related to Refined GitHub itself label Jul 2, 2020
@FloEdelmann
Copy link
Member Author

FloEdelmann commented Jul 3, 2020

It might be worth deleting getRepoURL and adding it to this line https://github.com/sindresorhus/refined-github/blob/daf633137ec08e6f5647a6f8bb0b02d5dce58ef9/source/github-helpers/index.ts#L8

Oh, indeed, I wanted to do that but forgot in this PR. We have to make it lowercase though, to not undo #2892.

@yakov116 yakov116 mentioned this pull request Jul 3, 2020
Merged
@FloEdelmann FloEdelmann deleted the rename-discussion-conversation branch July 4, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta Related to Refined GitHub itself

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FloEdelmann @fregante