Skip to content

Apply parse-backticks to more pages#3290

Merged
fregante merged 28 commits intorefined-github:masterfrom
kidonng:parse-backticks
Jul 16, 2020
Merged

Apply parse-backticks to more pages#3290
fregante merged 28 commits intorefined-github:masterfrom
kidonng:parse-backticks

Conversation

@kidonng
Copy link
Member

@kidonng kidonng commented Jun 26, 2020

Add/update the following selectors in the new layout:

@fregante fregante added the bug label Jul 1, 2020
@kidonng
Copy link
Member Author

kidonng commented Jul 3, 2020

There are more selectors to be added: Resolved

image (https://github.com/kidonng/readhub/blob/test/README.md)

@yakov116
Copy link
Member

yakov116 commented Jul 3, 2020

@kidonng I did not check if you already are since my git just corrupted itself (lost all my stashes 😢 and local branches)
But can you add support for
image

@kidonng
Copy link
Member Author

kidonng commented Jul 3, 2020

@yakov116 Nice, will add it now

Co-authored-by: Fregante <github@bfred.it>
@fregante
Copy link
Member

fregante commented Jul 7, 2020

Is this done?

@kidonng
Copy link
Member Author

kidonng commented Jul 8, 2020

Working on:

@kidonng kidonng marked this pull request as draft July 11, 2020 17:34
@fregante
Copy link
Member

* hovercards (hard to implement)
* Some non-code pages (Explore and Topics) 😄 Thought it isn't particularly useful

Let's skip these

@kidonng
Copy link
Member Author

kidonng commented Jul 13, 2020

Is there any concern about parsing the backticks in hovercards? I looked into linkify-user-location and found that it is not as complex as I thought. Maybe performance issues?

@fregante
Copy link
Member

found that it is not as complex as I thought

Let's try it then 👍

@kidonng kidonng marked this pull request as ready for review July 15, 2020 04:40
@fregante
Copy link
Member

I'll merge this for now, but I think this is a prime opportunity to try selector-observer: #3084

I keep seeing parts of the UI update and lose the parse-backticks formatting and I don't want to follow each and every part with observeElement

Can you try implementing it next? You can probably just merge every selector into one and keep using rgh-backticks-already-parsed to avoid them being re-parsed (which was the problem last time I tried the package)

@fregante fregante changed the title Update parse-backticks selectors Apply parse-backticks to more pages Jul 16, 2020
@fregante fregante merged commit cffceeb into refined-github:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants