Restore toggle-files-button+repo-age in "Repository refresh"#3264
Merged
fregante merged 2 commits intorefined-github:masterfrom Jul 1, 2020
FloEdelmann:restore-commit-tease
Merged
Restore toggle-files-button+repo-age in "Repository refresh"#3264fregante merged 2 commits intorefined-github:masterfrom FloEdelmann:restore-commit-tease
toggle-files-button+repo-age in "Repository refresh"#3264fregante merged 2 commits intorefined-github:masterfrom
FloEdelmann:restore-commit-tease
Conversation
FloEdelmann
changed the title
fregante
reviewed
Jun 26, 2020
| const commitInfo = await elementReady<HTMLAnchorElement | HTMLScriptElement>('.commit-tease a[href*="/commit/"], include-fragment.commit-tease'); | ||
| const commitInfo = await elementReady<HTMLAnchorElement | HTMLScriptElement>([ | ||
| // "Repository refresh" layout | ||
| '.Box-header--blue .hx_avatar_stack_commit + div a[href*="/commit/"]', |
Member
There was a problem hiding this comment.
Can this selector be improved/shortened?
Member
Author
There was a problem hiding this comment.
It could be shortened like this:
Suggested change
| '.Box-header--blue .hx_avatar_stack_commit + div a[href*="/commit/"]', | |
| '.Box-header--blue a[href*="/commit/"]', |
But since .Box-header--blue is quite generic (and I don't know if it is used elsewhere), I opted for more specific selector.
fregante
changed the title
toggle-files-button and repo-age in "Repository refresh" layout
fregante
changed the title
toggle-files-button and repo-age in "Repository refresh" layouttoggle-files-button+repo-age in "Repository refresh"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #3187 and #3225, related to #3081. GitHub updated the design of the "latest commit" box in the "Repository refresh" beta, so our selectors broke.
Restore
repo-ageTest URLs:
Make sure to clear the cache to test if the selectors work properly.
Restore
toggle-files-buttonTest URLs: see above