Fix download-folder-button and latest-tag-button
#3254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@FloEdelmann maybe throw #3195 (comment) in? |
fregante
reviewed
Jun 19, 2020
This was referenced Jun 22, 2020
Merged
busches
reviewed
Jun 30, 2020
fregante
reviewed
Jul 1, 2020
This reverts commit 5c97c91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Restore
download-folder-buttonin "Repository refresh" beta #3195 (comment).download-folder-buttondoesn't need to be shown when "Clone or download" button exists.Problem:
isRepoRootseems to not work on branches with slashes. It caused the big button to appear with "Repository refresh" beta disabled and a console error with "Repository refresh" beta enabled.Test: https://github.com/yakov116/TestR/tree/this/branch/has/many/slashes
Fixes Repo page completely broken when new feature preview enabled #3081 (comment) again after Add “Compare to HEAD” link next to
latest-tag-button#3214 was merged.Test: https://github.com/OpenLightingProject/open-fixture-library
Before:
After:
