Skip to content

Match border radius in GitHub new design #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 10 commits into from
Jul 1, 2020
Merged

Match border radius in GitHub new design #3247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dd15d83
Fix `reactions-avatars` border radius in "Design updates"
kidonng Jun 18, 2020
ca389e0
Inherit style
kidonng Jun 18, 2020
e6636e7
Lint
kidonng Jun 18, 2020
d724749
Match `parse-backticks` border-radius
kidonng Jun 24, 2020
05d5759
Match `clean-dashboard` border-radius
kidonng Jun 24, 2020
6f5f792
Match `clean-pinned-issues` border radius
kidonng Jun 24, 2020
dec41a8
Match `hide-watch-and-fork-count` border-radius
kidonng Jun 24, 2020
7b376c8
Match `highlight-collaborators-and-own-discussions` border radius
kidonng Jun 24, 2020
f424e8e
Match `minimize-upload-bar` border radius
kidonng Jun 24, 2020
3cb72e0
Match `recently-pushed-branches-enhancements` border radius
kidonng Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/features/clean-dashboard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
.dashboard .js-all-activity-header + div {
background-color: #fff;
border: 1px solid #d1d5da;
border-radius: 3px;
border-radius: 6px;
margin-top: 8px !important;
}

Expand Down
2 changes: 1 addition & 1 deletion source/features/clean-pinned-issues.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/* Rounded table border https://stackoverflow.com/a/2586780/288906 */
box-shadow: 0 0 0 1px #d1d5da;
border-collapse: collapse;
border-radius: 3px;
border-radius: 6px;
border-style: hidden;
}

Expand Down
5 changes: 0 additions & 5 deletions source/features/hide-watch-and-fork-count.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
/* The Watchers count visible (and clickable) when the dropdown is open */
/* This isn't possible for the Forks count because of an incompatible DOM structure and #2368 */
.rgh-hide-watch-and-fork-count:not(.rgh-forked-to) .btn-with-count[title^='Fork your own'],
.rgh-hide-watch-and-fork-count details:not([open]) .btn-with-count[data-ga-click^='Repository, click Watch'] {
border-radius: 0.25em; /* Matches GitHub's default */
}

.rgh-hide-watch-and-fork-count .social-count[href$='/network/members'],
.rgh-hide-watch-and-fork-count details:not([open]) ~ .social-count[href$='/watchers'] {
display: none;
Expand Down
2 changes: 1 addition & 1 deletion source/features/highlight-collaborators-and-own-discussions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.rgh-collaborator {
border: 1px solid #c0d3eb;
border-radius: 3px;
border-radius: 2em;
Copy link
Member Author

@kidonng kidonng Jun 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is border-radius of tags. 6px is fine though.

padding: 2px 5px;
}
1 change: 0 additions & 1 deletion source/features/minimize-upload-bar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@

.rgh-minimize-upload-bar .js-upload-markdown-image.is-default textarea {
border-bottom-style: solid;
border-radius: 3px;
}
2 changes: 1 addition & 1 deletion source/features/parse-backticks.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* Style copied from GitHub's <code> */
.rgh-parse-backticks {
background-color: rgb(27 31 35 / 5%);
border-radius: 3px;
border-radius: 6px;
font-size: 85%;
margin: 0;
padding: 0.2em 0.4em;
Expand Down
2 changes: 0 additions & 2 deletions source/features/reactions-avatars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ button.reaction-summary-item { /* `button` excludes the "Add reaction" icon */
display: inline-block;
width: 2em;
height: 2em;
border-radius: 3px;
margin-top: -0.3em;
margin-left: -0.5em;
vertical-align: middle;
Expand All @@ -45,6 +44,5 @@ button.reaction-summary-item { /* `button` excludes the "Add reaction" icon */
/* This image will start at height:0 and will expand once loaded, covering the gray placeholder */
.reaction-summary-item a img { /* `a` required for #3237 */
max-width: 100%;
border-radius: inherit;
background-color: var(--background);
}
4 changes: 2 additions & 2 deletions source/features/reactions-avatars.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ async function showAvatarsOn(commentReactions: Element): Promise<void> {
for (const {container, username, imageUrl} of flatParticipants) {
container.append(
// Without this, Firefox will follow the link instead of submitting the reaction button
<a href={isFirefox ? undefined : `/${username}`}>
<img src={imageUrl}/>
<a href={isFirefox ? undefined : `/${username}`} className="rounded-1 avatar-user">
<img src={imageUrl} style={{borderRadius: 'inherit'}}/>
</a>
);
}
Expand Down
3 changes: 1 addition & 2 deletions source/features/recently-pushed-branches-enhancements.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
background: none;
border-color: currentColor !important;
border-top: 1px solid !important;
border-radius: 5px;
background-color: #24292e;
}

Expand Down Expand Up @@ -74,7 +73,7 @@
font-size: 0;
line-height: 0;
border: solid 1px;
border-radius: 0.2rem;
border-radius: 6px;
}

.rgh-recently-pushed-branches [data-url$='recently_touched_branches_list'] .btn-link[href$='?expand=1']:not(:hover) {
Expand Down