Restore repo-age in "Repository refresh" beta
#3225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
requested changes
Jun 12, 2020
| .replace(/^an?/, '1') | ||
| .split(' '); | ||
|
|
||
| const secondSidebarSection = await elementReady('.repository-content .BorderGrid-row + .BorderGrid-row'); |
Member
There was a problem hiding this comment.
We should start marking these selectors so they can be all found and replaced once the issue is fixed.
Suggested change
| const secondSidebarSection = await elementReady('.repository-content .BorderGrid-row + .BorderGrid-row'); | |
| // TODO: simplify selector after https://github.com/sindresorhus/element-ready/issues/29 | |
| const secondSidebarSection = await elementReady('.repository-content .BorderGrid-row + .BorderGrid-row'); |
fregante
reviewed
Jun 12, 2020
Co-authored-by: Fregante <opensource@bfred.it>
fregante
approved these changes
Jun 18, 2020
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
This works, but it slows down the non-beta version since now elementReady will wait until the whole page has loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #3081, follows #3201 (comment).
Test this on any repo, e.g. https://github.com/sindresorhus/refined-github. Note that you should clear the cache to test if the commit link can be extracted correctly.