Skip to content

Fix button styles in "Repository refresh" beta #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 1 commit into from
Jun 16, 2020
Merged

Fix button styles in "Repository refresh" beta #3221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion source/features/default-branch-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,19 @@ async function init(): Promise<false | void> {

const defaultLink = (
<a
className="btn btn-sm tooltipped tooltipped-ne"
className="btn tooltipped tooltipped-ne"
href={String(url)}
aria-label="See this view on the default branch"
>
<ChevronLeftIcon/>
</a>
);

if (branchSelector.classList.contains('btn-sm')) {
// Pre "Repository refresh" layout
defaultLink.classList.add('btn-sm');
}

branchSelector.before(defaultLink);

const group = groupButtons([defaultLink, branchSelector]);
Expand Down
2 changes: 1 addition & 1 deletion source/features/latest-tag-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ async function init(): Promise<false | void> {
});

const link = (
<a className="btn btn-sm btn-outline ml-2" href={String(url)}>
<a className="btn btn-sm btn-outline ml-2 flex-self-center" href={String(url)}>
Copy link
Member

@fregante fregante Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌

<TagIcon/>
</a>
);
Expand Down
4 changes: 2 additions & 2 deletions source/features/list-prs-for-file.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function getPRUrl(prNumber: number): string {
function getDropdown(prs: number[]): HTMLElement {
// Markup copied from https://primer.style/css/components/dropdown
return (
<details className="ml-2 dropdown details-reset details-overlay d-inline-block">
<details className="ml-2 dropdown details-reset details-overlay d-inline-block flex-self-center">
<summary aria-haspopup="true" className="btn btn-sm">
<PullRequestIcon/> {prs.length} <div className="dropdown-caret"/>
</summary>
Expand All @@ -41,7 +41,7 @@ function getSingleButton(prNumber: number, _?: number, prs?: number[]): HTMLElem
return (
<a
href={getPRUrl(prNumber)}
className={'btn btn-sm btn-outline' + (prs ? ' BtnGroup-item' : '')}
className={'btn btn-sm btn-outline flex-self-center' + (prs ? ' BtnGroup-item' : '')}
>
<PullRequestIcon/> #{prNumber}
</a>
Expand Down