-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Restore bugs-tab in "Repository refresh" beta
#3205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your on 🔥 |
|
@FloEdelmann if you want to take care of this issue, I think it's only a matter of adding |
`data-hotkey` attributes are unique like IDs
fregante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Affected by this bug: #3001
Repro is different:
- Visit Bugs tab: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Abug
- Click the repository’s Pull requests tab
- Go back in the browser (
history.back())
source/features/bugs-tab.tsx
Outdated
| } | ||
|
|
||
| const issuesTab = (await elementReady('.pagehead [data-hotkey="g i"]'))?.parentElement; | ||
| const issuesTab = (await elementReady('[data-hotkey="g i"]'))?.parentElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The |
|
That can be done via Refer to the previous fix: af843eb In that case our code was fine, but it GitHub was adding the class due to |
|
The I suspect we can't remove it from the Issues tab, right? If the Issues tab still has it, however, GitHub will select it when going back to the Bugs tab (which is actually the Issues page). |
|
I've now tested removing |


References #3081.