Improve `latest-tag-button`’s reliability #3199

yakov116 · 2020-06-08T03:15:06Z

Closes #2927
Get only the last 20

Test https://github.com/sindresorhus/refined-github
1 commit https://github.com/Jin230/Git (Dont ask me how I found that repo 😄 )

More than 1 commit
https://github.com/sindresorhus/refined-github

More than 20 commits

Get only the last 20

source/features/latest-tag-button.tsx

yakov116 · 2020-06-08T11:31:45Z

@fregante just double checking were going with v2?

Co-authored-by: Fregante <opensource@bfred.it>

yakov116 · 2020-06-08T11:45:23Z

I think we should up it to 34-35 that is one page of commits.

source/features/latest-tag-button.tsx

Co-authored-by: Fregante <opensource@bfred.it>

yakov116 · 2020-06-08T18:08:49Z

I have a few questions:

Do you think we should up it to 34-35 since that is one page of commits. (https://github.com/sindresorhus/refined-github/commits/master)
Should I change the cache key to a string? Since I know you dont like when its __filebasename. It will also take care or the existing cache. (From what I understand it will expire anyways after 2 days)
The current layout is good? (Version 2)
When there are more than 20 commits you want to display 20+? or nothing?

fregante · 2020-06-08T20:18:49Z

Do you think we should up it to 34-35 since that is one page of commits. (master (commits))

Refer to #2927 (comment)

After all, the point of this information is to know whether we're on the latest commit. Anything above +20 (or missing/incorrect information) isn't particularly useful.

Should I change the cache key to a string? Since I know you dont like when its __filebasename. It will also take care or the existing cache. (From what I understand it will expire anyways after 2 days)

Sure.

The current layout is good? (Version 2)

👍

4. When there are more than 20 commits you want to display 20+? or nothing?

Refer to #3197 (comment)

This way we get the exact match if it's within the last 10/20/whatever commits, and if not, we don't have to guess, we just display "+".

20.6.4⁺

yakov116 · 2020-06-08T21:16:06Z

Do you think we should up it to 34-35 since that is one page of commits. (master (commits))

Refer to #2927 (comment)

After all, the point of this information is to know whether we're on the latest commit. Anything above +20 (or missing/incorrect information) isn't particularly useful.

I was thinking of any repo that does not do squash and merge 20 is a bit short. (But you can argue that 35 won't help)

Back on topic I Updated first post with pictures

I think the compare link should only show on isRepoRoot WDYT?

source/features/latest-tag-button.tsx

Co-authored-by: Fregante <opensource@bfred.it>

source/features/latest-tag-button.tsx

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>

source/features/latest-tag-button.tsx

Co-authored-by: Fregante <opensource@bfred.it>

fregante

Works great!

source/features/latest-tag-button.tsx

fregante · 2020-06-10T11:43:10Z

source/features/latest-tag-button.tsx

+		if (pageDetect.isRepoRoot()) {
+			const compareLink = (
+				<a
+					className="btn btn-sm btn-outline tooltipped tooltipped-ne"
+					href={`/${getRepoURL()}/compare/${latestTag}...${defaultBranch}`}
+					aria-label={`Compare ${latestTag}...${defaultBranch}`}
+				>
+					<DiffIcon/>
+				</a>
+			);
+			groupButtons([link, compareLink]);


Can you move this to a new PR?

Done want me to redo the first post screen shots?

Done want me to redo the first post screen shots?

They're kinda complex to do because I had to add padding around that area to make them "clean"

Also we need to wait for #3205 (comment)

Co-authored-by: Fregante <opensource@bfred.it>

yakov116 added 3 commits June 7, 2020 23:01

Use api to get latest-tag-button ahead count

93059df

Get only the last 20

V2 Design

9129520

Restore cache

b396780

fregante reviewed Jun 8, 2020

View reviewed changes

Apply suggestions from code review

586c440

Co-authored-by: Fregante <opensource@bfred.it>

yakov116 added 2 commits June 8, 2020 07:50

Apply most feedback

e7f0d3e

Change cache-key

6cd1c86

fregante reviewed Jun 8, 2020

View reviewed changes

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

yakov116 and others added 2 commits June 8, 2020 08:52

Update source/features/latest-tag-button.tsx

0a3f6c5

Co-authored-by: Fregante <opensource@bfred.it>

Clean Up

7836de5

fregante changed the title ~~Use api to get latest-tag-button ahead count~~ Improve latest-tag-button’s reliability Jun 8, 2020

yakov116 added 2 commits June 8, 2020 16:25

Change cache-key

445b73f

Feedback

ba5bfe3

yakov116 marked this pull request as ready for review June 8, 2020 21:14

fregante marked this pull request as draft June 9, 2020 09:02

fregante reviewed Jun 9, 2020

View reviewed changes

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

yakov116 and others added 2 commits June 9, 2020 07:25

Update source/features/latest-tag-button.tsx

de73edc

Co-authored-by: Fregante <opensource@bfred.it>

Only show the compare on repo root

1bf2539

yakov116 marked this pull request as ready for review June 9, 2020 11:30

Merge remote-tracking branch 'upstream/master' into latest-tag-from-api

3dff3d9

FloEdelmann reviewed Jun 9, 2020

View reviewed changes

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

Use ??

4743364

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>

fregante reviewed Jun 9, 2020

View reviewed changes

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

Update source/features/latest-tag-button.tsx

96e10d1

Co-authored-by: Fregante <opensource@bfred.it>

fregante approved these changes Jun 10, 2020

View reviewed changes

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

source/features/latest-tag-button.tsx Outdated Show resolved Hide resolved

fregante added enhancement bug labels Jun 10, 2020

fregante reviewed Jun 10, 2020

View reviewed changes

fregante removed the enhancement label Jun 10, 2020

yakov116 and others added 4 commits June 10, 2020 07:46

Apply suggestions from code review

7c977d8

Co-authored-by: Fregante <opensource@bfred.it>

Merge remote-tracking branch 'upstream/master' into latest-tag-from-api

0883f2c

Apply Suggestions

cb995bf

Remove compare link from this PR

178b70e

fregante merged commit e5c50bd into refined-github:master Jun 10, 2020

yakov116 deleted the latest-tag-from-api branch June 10, 2020 12:06

yakov116 mentioned this pull request Jun 10, 2020

Add “Compare to HEAD” link next to latest-tag-button #3214

Merged

Uh oh!

Improve latest-tag-button’s reliability #3199

Improve latest-tag-button’s reliability #3199

Uh oh!

Conversation

yakov116 commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yakov116 commented Jun 8, 2020

Uh oh!

yakov116 commented Jun 8, 2020

Uh oh!

Uh oh!

yakov116 commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yakov116 commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

yakov116 Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

yakov116 Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

fregante Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

yakov116 Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Improve `latest-tag-button`’s reliability #3199

Improve `latest-tag-button`’s reliability #3199

yakov116 commented Jun 8, 2020 •

edited

Loading

yakov116 commented Jun 8, 2020 •

edited

Loading

fregante commented Jun 8, 2020 •

edited

Loading

yakov116 commented Jun 8, 2020 •

edited

Loading