Skip to content

Use api to get the latest tag ahead count #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yakov116 wants to merge 6 commits into from
Closed

Use api to get the latest tag ahead count #3197

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45fe984
Use api to get the count
yakov116 Jun 7, 2020
e4d6bca
Github be consistent so I can go to sleep!!
yakov116 Jun 7, 2020
23a6186
Fix types (I think) and sort
yakov116 Jun 7, 2020
9f9f264
How about like this
yakov116 Jun 7, 2020
57c2f4b
No need to pass default branch
yakov116 Jun 7, 2020
1b5b8b5
Fix it
yakov116 Jun 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions source/features/latest-tag-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import './latest-tag-button.css';
import React from 'dom-chef';
import cache from 'webext-storage-cache';
import select from 'select-dom';
import TagIcon from 'octicon/tag.svg';
import elementReady from 'element-ready';
import * as pageDetect from 'github-url-detection';
Expand Down Expand Up @@ -65,23 +66,42 @@ const getRepoPublishState = cache.function(async (): Promise<RepoPublishState> =
}, {
maxAge: 1 / 24, // One hour
staleWhileRevalidate: 2,
shouldRevalidate: value => typeof value === 'string',
cacheKey: () => __filebasename + ':' + getRepoURL()
});

const getAheadByCount = cache.function(async (latestTag: string): Promise<string | undefined> => {
const aheadCount = await fetchDom(
`/${getRepoURL()}/releases/tag/${latestTag}`,
'.release-header relative-time + a[href*="/compare/"]'
);
// This text is "4 commits to master since this tag"
return aheadCount?.textContent!.replace(/\D/g, '');
const getAheadByCount = cache.function(async (latestTag: string): Promise<number> => {
const tagPage = await fetchDom(`/${getRepoURL()}/releases/tag/${latestTag}`);
const aheadCountOrTimeStamp = select.last('.release-header relative-time + a[href*="/compare/"], .release-header relative-time', tagPage)!;

return aheadCountOrTimeStamp instanceof HTMLAnchorElement ?
// This text is "4 commits to master since this tag"
Number(aheadCountOrTimeStamp.textContent!.replace(/\D/g, '')) :
// Github sometimes does not have the ahead count in the dom
getAheadCountApi(aheadCountOrTimeStamp.attributes.datetime.value);
}, {
maxAge: 1 / 24, // One hour
staleWhileRevalidate: 2,
cacheKey: ([latestTag]) => `tag-ahead-by:${getRepoURL()}/${latestTag}`
});

const getAheadCountApi = async (timeStamp: string): Promise<number> => {
const {repository} = await api.v4(`
repository(${getRepoGQL()}) {
defaultBranchRef {
target {
... on Commit {
history(first: 1, since: "${timeStamp}") {
totalCount
}
}
}
}
}
`);

return repository.defaultBranchRef.target.history.totalCount;
};

async function init(): Promise<false | void> {
const {latestTag, isUpToDate} = await getRepoPublishState();
if (!latestTag) {
Expand Down Expand Up @@ -120,9 +140,6 @@ async function init(): Promise<false | void> {
const defaultBranch = await getDefaultBranch();
if (currentBranch === defaultBranch) {
const aheadBy = await getAheadByCount(latestTag);
if (!aheadBy) {
return;
}

link.setAttribute('aria-label', `${defaultBranch} is ${aheadBy} commits ahead of the latest release`);
link.append(' ', <sup>+{aheadBy}</sup>);
Expand Down