Enable and apply unicorn/no-reduce
#3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Jun 3, 2020
| count += looseParseInt(reaction.textContent!); | ||
| } | ||
|
|
||
| return count; |
Member
Author
There was a problem hiding this comment.
| // If there are no tags in the repository | ||
| if (nodes.length === 0) { | ||
| return tags; | ||
| tags[commit].push(node.name); |
Member
Author
There was a problem hiding this comment.
| return description | ||
| .split(splittingRegex) | ||
| .reduce(splitTextReducer, new DocumentFragment()); | ||
| } |
Member
Author
There was a problem hiding this comment.
Test
Look at this very discussion’s title or a PR list: https://github.com/sindresorhus/refined-github/pulls
| return defaults; | ||
| }, {})); | ||
| return JSON.stringify(getFeatures().map(name => [`feature:${name}`, true])); | ||
| // TODO: unignore after https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42036 |
Member
Author
There was a problem hiding this comment.
Test
Visit the Options page
Member
Author
There was a problem hiding this comment.
Test doesn't pass. Fixing.
Edit: fixed in e226f9d
webpack.config.ts
Outdated
| entries[entry] = `./source/${entry}`; | ||
| return entries; | ||
| }, {}), | ||
| ].map(file => [file, `./source/${file}`])), |
Member
Author
There was a problem hiding this comment.
Test
If it compiles, it passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3168
With a few exceptions,
.reducedoesn't actually reduce (heh) the amount of code needed.