Skip to content

Conversation

@sindresorhus
Copy link
Member

No description provided.

@sindresorhus sindresorhus requested a review from fregante June 3, 2020 10:49
@fregante fregante added the meta Related to Refined GitHub itself label Jun 3, 2020
@sindresorhus
Copy link
Member Author

"target": "es2018", => "target": "es2020",?

@fregante
Copy link
Member

fregante commented Jun 3, 2020

I'm not entirely sure though, it's worth trying out the extension in both browsers. I think it's as easy as loading it: if it works without errors (content, options, background), then the browser supports the syntax

sindresorhus and others added 2 commits June 3, 2020 21:09
Co-authored-by: Fregante <opensource@bfred.it>
@sindresorhus
Copy link
Member Author

Webpack errors a lot when I change the output target:

ERROR in ./source/features/linkify-symbolic-links.tsx 7:29
Module parse failed: Unexpected token (7:29)
File was processed with these loaders:
 * ./node_modules/ts-loader/index.js
You may need an additional loader to handle the result of these loaders.
| import features from '.';
| function init() {
>     if (select('.file-mode')?.textContent === 'symbolic link') {
|         const line = select('.js-file-line');
|         wrap(line.firstChild, React.createElement("a", { href: line.textContent }));

I think that can be done later.

@fregante
Copy link
Member

fregante commented Jun 3, 2020

Webpack errors a lot when I change the output target:

Apparently due to acornjs/acorn#891

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. I'll open a new PR for the 2 things I mentioned: reduce and options’ init

sindresorhus and others added 2 commits June 3, 2020 21:32
Co-authored-by: Fregante <opensource@bfred.it>
@yakov116
Copy link
Member

Webpack errors a lot when I change the output target:

Apparently due to acornjs/acorn#891

https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.18 includes the acorn update

yakov116 added a commit that referenced this pull request Apr 25, 2021
Disabled "@typescript-eslint/no-non-null-assertion": not compatible with DOM
Disabled " @typescript-eslint/no-non-null-asserted-optional-chain"  See #3093 (comment) and #3168 (comment)
@yakov116 yakov116 mentioned this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

3 participants