Reset vertical-align for new octicons in js-issue-row #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR, but if this happens without Refined GitHub (which apparently does) we shouldn't fix it since they're probably still working on it. |
Contributor
Author
|
@fregante Thanks for taking a look. It does not look off without Refined Github for me, this is what it looks like in that case:
The |
Member
|
You're absolutely right! |
fregante
reviewed
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
fixes a misaligned icon I noticed after the recent
octiconsupdate. Not sure if this is the best way to go about it, feel free to close in case there is a better way to achieve this.Before:
After:
Thanks for maintaining this extension! ☀️