Skip to content

Add first-published-tag-for-merged-pr feature #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 38 commits into from
May 21, 2020
Merged

Add first-published-tag-for-merged-pr feature #3093

fregante merged 38 commits into from
May 21, 2020

Conversation

@yakov116
Copy link
Member

@yakov116 yakov116 commented May 13, 2020 •
edited by fregante
Loading

fregante
fregante reviewed May 13, 2020
View reviewed changes
@fregante fregante changed the title add pr-earliest-tag Add pr-earliest-tag feature May 13, 2020
@yakov116
Copy link
Member Author

yakov116 commented May 13, 2020

One issue, on browser back it get added again and again

image

@fregante
Copy link
Member

fregante commented May 13, 2020 •
edited
Loading

This means that #3084 can't work here (and maybe for any feature)

You can probably re-base this PR (fro master) and then use our regular approach for this.

@yakov116 yakov116 changed the base branch from linkify-everything to master May 14, 2020 11:29
@yakov116
Copy link
Member Author

yakov116 commented May 14, 2020 •
edited
Loading

@fregante I took the observe code from format-discussion-titles, since on new comments fires too early

Move it to its own file called onDiscussionTitleChange?

@fregante
Copy link
Member

fregante commented May 14, 2020

Move it to its own file called onDiscussionTitleChange?

Too tricky. If it works as is it's enough

@yakov116
Copy link
Member Author

yakov116 commented May 14, 2020 •
edited
Loading

Which one do you like better?

image

image

For now I did # 2

@yakov116 yakov116 changed the title Add pr-earliest-tag feature Add merged-pr-first-published-tag feature May 14, 2020
@yakov116 yakov116 marked this pull request as ready for review May 14, 2020 14:27
fregante
fregante requested changes May 14, 2020
View reviewed changes
Copy link
Member

@fregante fregante left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it on this old PR: #837

Ensure it takes the oldest tag, because on 87b2f4f there are dozens of tags.

yakov116 and others added 2 commits May 14, 2020 14:15
@yakov116
Copy link
Member Author

yakov116 commented May 14, 2020

Found a gacha.

Github sorts the tags by semver so if ther is one tag that does not follow semver, that becomes that last one.

Example: ovity/octotree#1
https://github.com/ovity/octotree/branch_commits/6c39b7f

@fregante
Copy link
Member

fregante commented May 14, 2020

It’s more likely that tags are sorted by date like everywhere else on the site. Either way if this info is available on the GraphQL API it’s still preferred

yakov116 and others added 5 commits May 14, 2020 16:04
@yakov116
Copy link
Member Author

yakov116 commented May 15, 2020

@fregante I reverted 031a49d since #837 will fail. It catches the force push event.

fregante
fregante reviewed May 15, 2020
View reviewed changes
readme.md Outdated
- [](# "pr-commit-lines-changed") [Adds diff stats on PR commits.](https://user-images.githubusercontent.com/16872793/76107253-48deeb00-5fa6-11ea-9931-721cde553bdf.png)
- [](# "cross-deleted-pr-branches") [Adds a line-through to the deleted branches.](https://user-images.githubusercontent.com/16872793/75619638-9bef1300-5b4c-11ea-850e-3a8f95c86d83.png)
- [](# "batch-mark-files-as-viewed") [Mark/unmark multiple files as “Viewed” in the PR Files tab. Click on the first checkbox you want to mark/unmark and then `shift`-click another one; all the files between the two checkboxes will be marked/unmarked as “Viewed”.](https://user-images.githubusercontent.com/1402241/79343285-854f2080-7f2e-11ea-8d4c-a9dc163be9be.gif)
- [](# "merged-pr-first-published-tag") [Shows the first tag a merged PR was published on.](https://user-images.githubusercontent.com/16872793/81943321-38ac4300-95c9-11ea-8543-0f4858174e1e.png)
Copy link
Member

@fregante fregante May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sindresorhus name/description suggestions?

Copy link
Member

@sindresorhus sindresorhus May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first-published-tag-for-merged-pr?

--

Shows the first Git tag a merged PR was included in.

@yakov116 yakov116 changed the title Add merged-pr-first-published-tag feature Add first-published-tag-for-merged-pr feature May 20, 2020
@fregante fregante merged commit 59ac921 into refined-github:master May 21, 2020
@yakov116 yakov116 deleted the pr-earliest-tag branch May 22, 2020 03:25
@yakov116
Copy link
Member Author

yakov116 commented Jun 3, 2020

@fregante this one didn't make it into the list

@fregante
Copy link
Member

fregante commented Jun 8, 2020

Remind me in July :D

@yakov116
Copy link
Member Author

yakov116 commented Jul 5, 2020

Remind me in July :D

its July :D

yakov116 added a commit that referenced this pull request Apr 25, 2021
@yakov116
Lint
d138202 
Disabled "@typescript-eslint/no-non-null-assertion": not compatible with DOM
Disabled " @typescript-eslint/no-non-null-asserted-optional-chain"  See #3093 (comment) and #3168 (comment)
@yakov116 yakov116 mentioned this pull request Apr 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show the earliest tag after a merged PR

3 participants

@yakov116 @fregante @sindresorhus