Skip to content

Conversation

@fregante
Copy link
Member

Fixes #2444

Test on a PR with more than 2 files, like https://github.com/sindresorhus/refined-github/pull/3006/files

@fregante fregante marked this pull request as ready for review April 15, 2020 13:38
@fregante
Copy link
Member Author

I want to make 2 more changes:

  • Add alt-click to toggle all
  • Add a "in progress" indicator next to the counter, where I circle in the gif

@fregante fregante marked this pull request as draft April 17, 2020 10:40
@fregante fregante marked this pull request as ready for review April 29, 2020 17:26
@fregante
Copy link
Member Author

I'll merge this as is and I'll leave those 2 changes in a separate issue, if anyone wants to tackle them: #3043

@fregante fregante merged commit 9ec4250 into master Apr 29, 2020
@fregante fregante deleted the batch-mark-files-as-viewed branch April 29, 2020 17:36
@fregante fregante mentioned this pull request Jun 3, 2020
@b-hayes
Copy link

b-hayes commented Jun 10, 2021

Really need a way to mark all deleted files as viewed in one go if that can be added.
Or even just a way to mark ALL as viewed and claps all and just scroll through the names of such enormous PR's and untick specific files of interest.
image

@b-hayes
Copy link

b-hayes commented Aug 26, 2021

Is all this meant to be working now? alt / shift clicks?

@yakov116
Copy link
Member

You may nwed to refresh the page. (Sorry can't link the correct issue as I am on mobile)

@mfb2
Copy link

mfb2 commented Oct 8, 2021

Is this actually implemented? I just tried it and it doesn't work.

@arthurio
Copy link

It feels like that used to work and it's no longer the case?

@cheap-glitch
Copy link
Contributor

It feels like that used to work and it's no longer the case?

It's working for me:

capture-1634118641.mp4

@arthurio if it's definitely broken for you, could you open an issue or provide a public URL where this can be reproduced? 🙏 Thank you

@arthurio
Copy link

@cheap-glitch I'm using a mac, maybe I'm trying the wrong key press combination? I tried:

  • option + shift + click
  • cmd + shift + click
  • cmd + click
  • option + click

None of those worked ¯_(ツ)_/¯

@cheap-glitch
Copy link
Contributor

I'm using a mac, maybe I'm trying the wrong key press combination?

It's a simple Shift + click, like in file browsers. Just tested right now and it's working for me on Firefox (Arch Linux).

Maybe it's a browser bug, you're on Safari I presume?

@arthurio
Copy link

I'm using Chrome, but also tried Firefox... Shift + click doesn't work either 😢

https://www.loom.com/share/150d7721e07f4effa535706183ce34d9

@fregante
Copy link
Member Author

Thanks for the video. I'm not sure either. The correct sequence is:

  1. Click on first item
  2. Hold shift
  3. Click on other item
  4. Release shift

And steps 2-4 can be repeated to continue the selection.

Are you using the left shift? Maybe that's it. Or maybe CAPS LOCK is enabled? 😅

@arthurio
Copy link

@fregante It works great! I had some weird key binding conflicts 👍🏻 Thanks a lot for your help!

@jonhendershot
Copy link

@fregante It works great! I had some weird key binding conflicts 👍🏻 Thanks a lot for your help!

@arthurio mind sharing what conflicts you had and how you resolved them? think i may be having the same issue

@chrisshaddad
Copy link

chrisshaddad commented Mar 7, 2022

@arthurio - I'm struggling to get this to work on my mac, mind sharing what key bindings you changed?

Time to share something super dumb, in hopes of helping someone who reached here and still doesn't have this working 😂

I didn't realise this wasn't an official github issue, it's actually a browser extension you have to install before you can use this feature, and it works perfectly.

@arthurio
Copy link

arthurio commented Mar 7, 2022

I'm using vimium with chrome, I just disabled it for github and it worked.

What browser do you use? What's your version of the github-refined extension?

@chrisshaddad
Copy link

@arthurio - Thank you for the quick reply! Much appreciated, I figured it out, I had to install refined-github first 😭🔫

@arthurio
Copy link

arthurio commented Mar 7, 2022

@chrisshaddad Haha yeah... It's not 100% obvious TBH so don't feel bad 😄 I have been using it for couple months now and I love it! Enjoy 😉

@devibrahimkarahan
Copy link

Thanks for the video. I'm not sure either. The correct sequence is:

  1. Click on first item
  2. Hold shift
  3. Click on other item
  4. Release shift

And steps 2-4 can be repeated to continue the selection.

Are you using the left shift? Maybe that's it. Or maybe CAPS LOCK is enabled? 😅

It doesnt work with Shift, Chrome 114.0.5735.198

@yakov116
Copy link
Member

yakov116 commented Jul 6, 2023

@devibrahimkarahan Don't comment on a 3 year old post. Open a new issue.

@refined-github refined-github locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

Mark all files as viewed/not-viewed

10 participants