Skip to content

Improve forked-to reliability #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 3 commits into from
Mar 16, 2020
Merged

Improve forked-to reliability #2892

fregante merged 3 commits into from
Mar 16, 2020

Conversation

@fregante
Copy link
Member

@fregante fregante commented Mar 14, 2020

Closes #2759
Closes #2885

Cases tested:

  • User has no organizations (no action taken)
  • User has 1 fork (icon shown)
  • User has 1 fork and is currently visiting it (no icon shown)
  • User has 2 forks (dropdown shown)
  • User has 2 forks and is currently visiting 1 (dropdown shown, 1 fork selected)

Screen Shot 2020-03-14 at 18 25 24

Edge cases that work but aren't strictly supported:

  • User has forked a fork (the "source" repo points to the first fork, so the UI might not be exactly what's expected)

@fregante fregante added the bug label Mar 14, 2020
@fregante fregante merged commit 3ac1076 into master Mar 16, 2020
@fregante fregante deleted the forked-to-fix branch March 16, 2020 14:15
@fregante fregante mentioned this pull request Mar 20, 2020
Closed
@FloEdelmann FloEdelmann mentioned this pull request Jul 3, 2020
Merged
@yakov116 yakov116 mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

forked-to is broken Duplicate forks in forked-to

1 participant

@fregante