-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add 3 file-finder-related features
#2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 file-finder-related features
#2825
Conversation
fregante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesss! Thank you
|
@fregante
|
dc09db2 to
7b4ff75
Compare
|
Looks good so far! I’m not sure when I’ll get around testing the code though |
`sessionStorage` is persisted for too long and appears in other tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
preserve-file-finder-term could have a quick gif similar to the one below (I used Licecap), showing the mouse clicking the back button.
|
The interesting part is that GitHub already has a |
|
I hope to see this merged soon, it's only missing descriptions and screenshots.
This can be done in a later PR, perhaps, so this one is merged asap. |
|
@fregante Yes, I'll look into the description & screenshots over the weekend. |
|
I never thought this'd see the day! |
Closes #2467. Adds 2 new features, which are improvements to the
tfile finder:Repo-wide file finder shortcut (
repo-wide-file-finder): Currently, GH supports thetshortcut only in paths with/blobor/treein them. Added a hidden button withdata-hotkeyso that thetworks throughout other tabs in the repo, (eg: Issues, Releases, etc.)Preserves search term in file finder (
preserve-file-finder-term.tsx): The search term in file finder is persisted ( in local storage ) across file finder invocations. Also, the keys pressed immediately following thetare persisted in a buffer and added to the search term. If buffer is present, the buffer is used, otherwise the value from previous search is used.Kindly review and let me know if the features need to be added elsewhere (
README, etc.). Thanks!IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor