-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Tell me whether master is the latest published version #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On this repo: https://github.com/fregante/select-dom The tag 6.0.0 has hash 85bdd9291fa7c7e75171d773e90ec9b5d0bbd8c9 but its commit is 75ec114f45c1dafcc0664011939b560b6f30bd09
|
I think this feature is 🔥 |
|
Possible improvements:
While I think this piece of information is important, maybe it shouldn't look like such a big problem. The "info" icon doesn't seem right either Other options: https://octicons.github.com/ |
|
https://octicons.github.com/icon/dashboard/ ? It looks like a speedometer to me 😀 |
|
Completely agree on the icon @fregante - it does make it look like there's a problem. The info-icon is better, IMO, as it simply denotes an informatory message. Is the eye-icon an alternative? Basically saying "Hey, have a look here, there's something you might want to pay attention to" |
That icon means visible (or hidden). You're describing the Info icon, but I think this information is slightly more "urgent" that that. It sits somewhere between Info and Warning If we had a Or maybe this indicator should be in the branch selector instead. 😅 |
|
Anything I can do to help move this along @fregante @sindresorhus? |
|
Looks great! |
|
Strangely the second call is failing on https://github.com/fregante/webext-storage-cache It's the const getAheadByCount = webext_storage_cache["a"].function(async latestTag => {
const tagPage = await fetch_dom(`/${Object(utils["j"])()}/releases/tag/${latestTag}`);
return Object(select_dom["a"])('.release-header relative-time + a[href*="/compare/"]', tagPage).textContent.replace(/\D/g, "");
}, {
expiration: 1,
cacheKey: () => "latest-tag-button" + ":aheadBy:" + Object(utils["j"])()
}); |
|
@bblommers thanks this feature is awesome! |








Fixes #2601
If understood correctly, there are three use cases here:
Test
The last test case now has a new icon:
IssueHunt Summary
IssueHunt has been backed by the following sponsors. Become a sponsor