Skip to content

ci-link should only refer to the default branch (+ minor fixes) - #2644

Merged
fregante merged 11 commits into
masterfrom
ci-link-improvements
Jan 6, 2020
Merged

fregante merged 11 commits into
masterfrom
ci-link-improvements

Conversation

@fregante

@fregante fregante commented Dec 19, 2019 •

Copy link
Copy Markdown
Member

GitHub already shows the status for the current branch: #2317

ci-link now only refers to the repo as a whole.

Test

  • Test

https://github.com/sindresorhus/refined-github
https://github.com/sindresorhus/refined-github/tree/b8614bdfee788989f5032b0f83afdd0af012904d

GitHub already shows the status for the current branch. `ci-link` now only refers to the repo as a whole.
For some reason `import getCurrentBranch` was pointing to `getDefaultBranch`, a sync function, making XO mark it as an error.

VSCode also followed the same flawed logic. 🤷‍♂️
@fregante fregante changed the title ci-link should only refer to the default branch (+ minor fixes) WIP: ci-link should only refer to the default branch (+ minor fixes) Jan 5, 2020
fregante and others added 5 commits January 6, 2020 19:45
After all the changes, you still need to change the west/east positioning class, and this is starting to look like a lot of moving parts just to avoid a fetch that is catched between ajaxed loads.
@fregante fregante changed the title WIP: ci-link should only refer to the default branch (+ minor fixes) ci-link should only refer to the default branch (+ minor fixes) Jan 6, 2020
@fregante

fregante commented Jan 6, 2020

Copy link
Copy Markdown
Member Author

I dropped all the unrelated changes I had previously made in this PR. Some were moved to #2670

@fregante
fregante merged commit dac2a03 into master Jan 6, 2020
@fregante
fregante deleted the ci-link-improvements branch January 6, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant