Restore and extend url linkifier #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2019
Member
|
Weird, I'm not getting anything linkified when running this PR locally. |
Member
Author
|
Did you run npm install? |
Member
|
Yup. I tried checking out the branch fresh, reinstalled node_modules, and then reloaded the extension. This is not linkified: https://github.com/sindresorhus/refined-github/pull/546/files#diff-36280fbf56b6409696e3d46d6b30118fR51 |
Member
Author
|
Classic! I had extracted the |
Member
|
Still doesn't work for me. |
Member
Author
|
The push must have failed. Flaky internet |
sindresorhus
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695 (oldest bug open)
Fixes #1499
Thanks to https://github.com/bfred-it/zip-text-nodes. Comments welcome on this package and its name too
Test
URLs in diffs
https://github.com/Homebrew/homebrew-core/pull/18015/files
URLs in regular files
/source/features/copy-markdown.js@
3f5fc48#L45URLs in PR files
https://github.com/sindresorhus/refined-github/pull/546/files#diff-36280fbf56b6409696e3d46d6b30118fR51
URLs in embedded code
https://github.com/sindresorhus/refined-github/blob/3f5fc489e417d4f4a14da5ea423775e9ca9246fd/source/features/copy-markdown.js#L45
Issue reference in file
/source/features/sort-issues-by-update-time.tsx@
2ade9a8#L18Issue reference in embedded code
https://github.com/sindresorhus/refined-github/blob/2ade9a84b1894c7879fab9d3e2d045e876f941a6/source/features/sort-issues-by-update-time.tsx#L18