Skip to content

Update dashboard style #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 5 commits into from
Mar 12, 2019
Merged

Update dashboard style #1824

fregante merged 5 commits into from
Mar 12, 2019

Conversation

@fregante
Copy link
Member

@fregante fregante commented Mar 5, 2019

Before

After

@sindresorhus
Copy link
Member

sindresorhus commented Mar 5, 2019

Looks better.

Maybe horizontally align the top of the avatar with the top of the title?

screen shot 2019-03-05 at 12 32 08

@nesl247
Copy link
Contributor

nesl247 commented Mar 5, 2019

I think it looks worse this way. Maybe it would be better to have the whole contents in the white box instead of the title and timestamp outside of it? The text doesn't contrast enough with the background color IMO.

@fregante
Copy link
Member Author

fregante commented Mar 6, 2019 •
edited
Loading

How about this?

screenshot 2019-03-06 at 10 02 45

@sindresorhus I condensed the lines as (I thought you) requested but maybe they're a bit tight like that. Maybe I should just align it to the top.

@nesl247
Copy link
Contributor

nesl247 commented Mar 6, 2019

@bfred-it That looks really good.

@fregante
Copy link
Member Author

fregante commented Mar 6, 2019 •
edited
Loading

Also perhaps I should drop the updated __/__ from "Created repository" events

@fregante
Copy link
Member Author

fregante commented Mar 6, 2019

Here are some new and comprehensive styles:

screenshot 2019-03-06 at 11 18 22

screenshot 2019-03-06 at 11 18 49

screenshot 2019-03-06 at 11 18 34

@fregante fregante mentioned this pull request Mar 6, 2019
Closed
@fregante fregante changed the title Drop "white box" for dashboard events Update dashboard style Mar 8, 2019
@fregante
Copy link
Member Author

fregante commented Mar 12, 2019

Let's give this a go

@fregante fregante merged commit 70814dc into master Mar 12, 2019
This was referenced Mar 14, 2019
Closed
Merged
@fregante fregante mentioned this pull request Jan 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fregante @sindresorhus @nesl247