More useful 404 page #1531
Closed
More useful 404 page #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
requested changes
Sep 16, 2018
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
I think this is overly specific, it shouldn’t work only for a subset of URLs but for all 404s. Just split the pathname and query each part (perhaps skipping or modifying parts we recognize)
The solution was overly specific, so we changed it to work for all 404s. We ignore some paths that are never reachable (right now `tree` and `blob`). For now it also doesn't change `blob` to `commits` anymore.
Contributor
Author
|
@bfred-it Okay I made it less specific. Right now it ignores Here are 404 pages I found/looked at, if you have more please let me know.
|
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature makes the 404 page more useful. Fixes #485.
I'm not to sure if this is already the best we can do but it's a start.
I'm happy for suggestions/improvements.
To-do
readmewith screenshot