Skip to content

extensible-nav - Render nav icons when no tooltip container is found - #10385

Draft
fregante wants to merge 1 commit into
mainfrom
claude/tooltip-portal-fallback
Draft

fregante wants to merge 1 commit into
mainfrom
claude/tooltip-portal-fallback

Conversation

@fregante

@fregante fregante commented Nov 9, 2026

Copy link
Copy Markdown
Member

Created by Claude, will be reviewed by @fregante first.

The nav tooltip threw ElementNotFoundError when none of its portal containers existed, which aborted rendering of the Security/Insights/Wiki icons. It now falls back to document.body.

Fixes #10383

Related: #10071, #10122, #10037

Test URLs:

Checked: the code path and that no other open PR touches tooltip.svelte.
Not checked: the actual page. The report only happens with GitHub's command palette feature preview disabled, which needs a logged-in session. Reviewer task: on https://github.com/refined-github/refined-github with that preview off, confirm the nav icons render.

Co-authored-by: Claude <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

[extensible-nav] Security/Insights/Wiki icons are not rendered in nav bar

1 participant