Repository navigation
Conversation
|
All PRs must include screenshots showing the changes or fixes. This looks like an AI-generated PR, "tests pass" is not an excuse. Next steps:
Tips:
|
github-actions
Bot
changed the title
github-actions-indicators for updated Actions sidebar
Author
|
Hi! Since the bot mentioned missing screenshots, I've changed them from HTML to Markdown in case that was the issue. I also added a few more details to the description. Hopefully someone can take another look and reopen the PR if everything is okay. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #10375.
The
github-actions-indicatorsfeature stopped working because GitHub changed the HTML structure of the Actions sidebar.I updated the selectors to match the new structure and fixed the workflow filename extraction so query parameters don't cause problems.
What I changed
While looking into the issue, I noticed that the old selector couldn't find any workflow links anymore. GitHub now uses
Sidebar.Iteminstead of the previous<li>elements.I also had to update the selectors for the pin button and workflow labels to get both indicators working again.
Test URLs
Screenshots
Before (Broken workflow indicators)
The workflow sidebar before the fix. Scheduled run times were not displayed.
After 1 (Scheduled workflow indicator)
The
Dailyworkflow now correctly shows its next scheduled run (in 16 hours). No manual trigger button is shown because I don't have permission to run workflows in the original repository.After 2 (Manual workflow trigger button)
In my fork, the play button now appears next to
Release. Clicking it successfully opens the workflow dispatch menu without starting the workflow.Testing
Tested locally in Chrome and Firefox.