Repository navigation
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Member
Author
Member
Author
|
Problems:
Human checklist:
|
fregante
commented
Nov 1, 2026
…eviews Co-authored-by: Claude <noreply@anthropic.com>
Member
Author
|
Fixed both problems in 3db1a64: the order is now Comment, Request changes, Approve, and the feature doesn’t touch the dialog when only Comment is available (for example on your own PR). |
…e submit button Co-authored-by: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Created by Claude, will be reviewed by @fregante first.
Rewrites the feature as a Svelte component for the new "Finish your review" dialog, following your plan in #8711: Comment, Approve and Request changes buttons replace the native radios and submit button (hidden, not removed, since React owns them), disabled states keep their native explanation as a tooltip, and a small
xrestores the native controls. Buttons are ordered Comment, Request changes, Approve, and the dialog is left alone when only Comment is available. There is no<form>in the new dialog, so a click selects the matching radio and then clicks the native submit button.Fixes #8711
Test URLs
Checked
Not checked (needs a login, reviewer task)
xin a real browser.commentregardless, the delay needs adjusting.