Skip to content

one-click-review-submission - Restore feature - #10334

Draft
fregante wants to merge 3 commits into
mainfrom
claude/one-click-review-svelte
Draft

fregante wants to merge 3 commits into
mainfrom
claude/one-click-review-svelte

Conversation

@fregante

@fregante fregante commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Created by Claude, will be reviewed by @fregante first.

Rewrites the feature as a Svelte component for the new "Finish your review" dialog, following your plan in #8711: Comment, Approve and Request changes buttons replace the native radios and submit button (hidden, not removed, since React owns them), disabled states keep their native explanation as a tooltip, and a small x restores the native controls. Buttons are ordered Comment, Request changes, Approve, and the dialog is left alone when only Comment is available. There is no <form> in the new dialog, so a click selects the matching radio and then clicks the native submit button.

Fixes #8711

Test URLs

Checked

  • Selectors and structure are based on the dialog HTML you pasted from your own PR (logged in). Not seen: the dialog on a PR where Approve and Request changes are enabled, or the pending-review state with comments.
  • Type-checks and builds against the repo's own tooling.

Not checked (needs a login, reviewer task)

  • Nothing was run on github.com: the dialog only exists logged in, so I couldn't try the click flow, the hiding, or the x in a real browser.
  • Whether selecting the radio and then clicking the native button right after one tick makes React submit the right review type. If it submits comment regardless, the delay needs adjusting.
  • Whether the radios and the submit button are already rendered when the dialog appears: the observer now only waits for the dialog, so the feature would throw if they come later.
  • Whether ⌘⏎ still submits the default (Comment) review through the hidden native button.
  • The readme screenshot still shows the old UI.

Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the bug label Oct 26, 2026
@fregante

fregante commented Nov 1, 2026

Copy link
Copy Markdown
Member Author
Screenshot 6

@fregante

fregante commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Problems:

  • order is bad, "approve" should be right-most
  • it probably should not affect PRs where you cannot approve/request changes, the button is still only one

Human checklist:

  • Test manually in more scenarios

…eviews

Co-authored-by: Claude <noreply@anthropic.com>
@fregante

fregante commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Fixed both problems in 3db1a64: the order is now Comment, Request changes, Approve, and the feature doesn’t touch the dialog when only Comment is available (for example on your own PR).

…e submit button

Co-authored-by: Claude <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

one-click-review-submission doesn't work

1 participant