Repository navigation
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
…ync out of `replace` Co-authored-by: Claude <noreply@anthropic.com>
# Conflicts: # source/features/extensible-nav.tsx
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Claude, will be reviewed by @fregante first.
Re-reads GitHub's native nav whenever its current tab or its limited-PRs icon changes, so the extensible nav no longer keeps whatever GitHub had rendered at the moment it first read it.
DomChefnow re-renders when itsaschanges, because it only rendered once.Fixes #10122
Fixes #10037
Test URLs
https://github.com/refined-github/refined-github
https://github.com/refined-github/refined-github/pulse
High counters https://github.com/microsoft/vscode
Blocked PRs https://github.com/sindresorhus/eslint-plugin-unicorn
Also the repro from #10037: https://github.com/sindresorhus/awesome
Possibly related, not touched here: #10317
Checked
Chromium, logged out, with the built extension on the server-rendered markup of https://github.com/refined-github/refined-github and GitHub's scripts blocked. I then mutated the native nav the way GitHub would after the extension has read it, on
mainand on this branch:aria-currentfrom Code to Issues:mainkeeps Code selected, this branch selects Issues.mainkeeps the normal icon, this branch shows the locked one.Not checked (reviewer tasks)
extensible-navsometimes lags behind #10122 is not addressed.