Skip to content

conversation-activity-filter - Add to PR sticky header - #10325

Merged
fregante merged 4 commits into
mainfrom
claude/activity-filter-sticky-header
Oct 26, 2026
Merged

fregante merged 4 commits into
mainfrom
claude/activity-filter-sticky-header

Conversation

@fregante

@fregante fregante commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Created by Claude, will be reviewed by @fregante first.

closes #10228, redone from scratch to address the review there: one selector for the sticky header, no :is(), the PH_Actions order rule and the anchor change are dropped, and the breakpoint is 1075px.

Follow-up to #10187. Related: #10169

  • Observes the PR sticky header title area, so the widget is also there while scrolling
  • Shows it after the title there with a single order rule
  • Hides it there when the window is 774px wide or narrower
  • Narrow-layout rule now applies up to 1075px

Test URLs

#4030 (scroll down to show the sticky header; narrow the window to check the layout)
#10169

Checked

Not checked

Reviewer tasks

  • Sticky header on a PR: widget appears after the title, header not resized
  • Sticky header at 774px or narrower: widget is hidden
  • Window narrower than 1075px on a PR and on an issue: primary button (Merge, New issue) stays first

@fregante
fregante marked this pull request as draft October 25, 2026 13:03
@fregante
fregante marked this pull request as ready for review October 26, 2026 06:58
@fregante

Copy link
Copy Markdown
Member Author

Currently appears on the left side due to the weird width on the PR sticky header. Ideally it would still be on the right side but it's better than nothing for now.

Screenshot

@fregante
fregante merged commit 6069cf2 into main Oct 26, 2026
21 checks passed
@fregante fregante added the bug label Oct 26, 2026
@github-actions

Copy link
Copy Markdown

To maintainers: Please add labels to this PR

@fregante
fregante deleted the claude/activity-filter-sticky-header branch October 26, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants