Skip to content

reactions-avatars - Restore on issues - #10264

Merged
fregante merged 6 commits into
mainfrom
claude/reactions-avatars-react-issues
Oct 19, 2026
Merged

fregante merged 6 commits into
mainfrom
claude/reactions-avatars-react-issues

Conversation

@fregante

Copy link
Copy Markdown
Member

Created by Claude, will be reviewed by @fregante first.

The React issue view only lists the full names of the reactors, not their usernames. The reactors of all comments in view are now fetched in a single batched GraphQL request (comments by node ID, the description by issue number), using the avatar URLs from the API. This path needs a token, without one no avatars are shown there.

Fixes #10048

Test URLs:

Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the bug label Oct 17, 2026
fregante and others added 3 commits October 17, 2026 16:53
…ons at 9

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
@fregante

Copy link
Copy Markdown
Member Author

Freaking one-shotted. Didn't even have access to the dom 🤷‍♂️

Screenshot 1 Screenshot

fregante and others added 2 commits October 19, 2026 06:58
Co-authored-by: Claude <noreply@anthropic.com>
@fregante
fregante marked this pull request as ready for review October 19, 2026 07:06
nodes {
... on Actor {
login
avatarUrl(size: ${avatarSize * 2})

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response-wise, this is pretty heavy. However it's guaranteed to work for bots/apps too. Maybe at some point I'll restore the previous "bot guessing" logic instead, if the api already returns whether the user is a bot.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this currently, which does not contain [bot] or anything like that. We'll see. At least it already works.

					{
						"content": "EYES",
						"reactors": {
							"nodes": [
								{
									"login": "copilot-swe-agent",
									"avatarUrl": "https://avatars.githubusercontent.com/in/1143301?s=32&v=4"
								}
							]
						}
					}
				]

@fregante fregante changed the title reactions-avatars - Fix on React issues reactions-avatars - Restore on issues Oct 19, 2026
@fregante
fregante enabled auto-merge (squash) October 19, 2026 07:06
@fregante
fregante merged commit 1734bf8 into main Oct 19, 2026
20 checks passed
@fregante
fregante deleted the claude/reactions-avatars-react-issues branch October 19, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

reactions-avatars - Broken on Issues

1 participant