Skip to content

show-names implemented by GitHub? #9972

Description

@kidonng

I noticed names are showing up in https://github.com/microsoft/vscode. Could be a gradual rollout.

GitHub's implementation covers more places like issue list:

Image

Our code already does the right thing by filtering out non-usernames, but the comment could be misleading (it only states one case, not the actual motivation):

const users = Map.groupBy(
// Exclude nested items https://github.com/refined-github/refined-github/pull/8661
found.filter(element => element.textContent.trim() === element.href.split('/').pop()),
element => element.textContent.trim(),
);

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions