Description
Just noticed: all features are inited twice everywhere.
First load:
- sync run
soft-nav:react-done
Successive loads
turbo:render
soft-nav:react-done
Caused by:
The fact that we're not suddenly getting duplicate content everywhere shows that our deduplication logic and policy is doing a decent job 🙌
|
} while (await oneEvent(document, ['turbo:render', 'soft-nav:react-done'])); |
I think the solution would be to uniquely identify page loads in that loop. I'm not sure if URL-based deduplication is enough, maybe it is. e.g.
if URL === lastURL, skip, else set lastURL = URL
How to replicate the issue + URL
- Enable
Show the features enabled on each page in the console
- filter
archive-forks-link since it's enabled on all repo pages
- see it appear twice every time
Extension version
26.78.3
Browser(s) used
safari
Token ⚠️
Description
Just noticed: all features are inited twice everywhere.
First load:
soft-nav:react-doneSuccessive loads
turbo:rendersoft-nav:react-doneCaused by:
The fact that we're not suddenly getting duplicate content everywhere shows that our deduplication logic and policy is doing a decent job 🙌
refined-github/source/feature-manager.tsx
Line 235 in ba8a9ef
I think the solution would be to uniquely identify page loads in that loop. I'm not sure if URL-based deduplication is enough, maybe it is. e.g.
if
URL===lastURL, skip, else setlastURL=URLHow to replicate the issue + URL
Show the features enabled on each page in the consolearchive-forks-linksince it's enabled on all repo pagesExtension version
26.78.3
Browser(s) used
safari
Token⚠️