Skip to content

netiquette is broken #8908

Closed
Closed

Description

@jdreesen

Description

Image Image

How to replicate the issue + URL

Go to twigphp/Twig#4288 and scroll to the bottom.

Extension version

26.1.24

Browser(s) used

Firefox 147.0.1 on Ubuntu 24.4

Token ⚠️

  • I set a token in the options page. I understand that some features require a token to work.

Activity

  1. changed the title [-]netiquette is broken[/-] [+]`netiquette` is broken[/+] on Jan 26, 2026
  2. keysmashes commented on Jan 26, 2026

    @keysmashes
    Contributor

    for posterity: this was partly hidden by #8817 only fixing addPopularBanner, not addResolvedBanner. I was about to file a one-line PR to fix it:

    diff --git a/source/features/netiquette.tsx b/source/features/netiquette.tsx
    index 8c4c629a54..89e67e97f2 100644
    --- a/source/features/netiquette.tsx
    +++ b/source/features/netiquette.tsx
    @@ -77,6 +77,7 @@
     	});
    
     	if (reactWrapper) {
    +		reactWrapper.parentElement?.classList.add('flex-column');
     		reactWrapper.before(banner);
     	} else {
     		banner.classList.replace('rounded-0', 'm-2');

    but it looks like there's a PR already that reworks the feature to eliminate the code duplication.

  3. added a commit that references this issue on Jan 26, 2026
  4. github-actions commented on Jan 26, 2026

    @github-actions

    To maintainers: Disable the hotfix by adding 26.1.26 to https://github.com/refined-github/yolo/edit/main/broken-features.csv

  5. keysmashes commented on Feb 16, 2026

    @keysmashes
    Contributor

    fwiw: this appears to still be broken for me, with rgh 26.2.3.

  6. shuuji3 commented on Feb 19, 2026

    @shuuji3

    I also found the same issue now and the above patch fixed the issue 🙏🏻

  7. shuuji3 commented on Feb 19, 2026

    @shuuji3

    Created a PR to fix this issue (+ draft PR issue)

  8. added a commit that references this issue on Feb 19, 2026
  9. SunsetTechuila commented on Feb 19, 2026

    @SunsetTechuila
    Contributor

    I've disabled the feature again

  10. fregante commented on Feb 19, 2026

    @fregante
    Member

    What's the situation? Is it fixed on main? Should I release a new version? Should this issue be reopened?

  11. SunsetTechuila commented on Feb 19, 2026

    @SunsetTechuila
    Contributor

    What's the situation?

    #8987 (comment) (the second part)

    Is it fixed on main?

    Yes

    Should this issue be reopened?

    No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdisabled via hotfixA label to remind us to remove the feature from yolo

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions