You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
rgh-netiquette: Cannot read properties of undefined (reading 'getAttribute') #8296
TypeError: Cannot read properties of undefined (reading 'getAttribute')
at getCloseDate (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/features/netiquette.js:24:38)
at wasClosedLongAgo (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/features/netiquette.js:47:22)
at init (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/features/rgh-netiquette.js:52:7)
at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/feature-manager.js:167:26
at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/helpers/async-for-each.js:6:52
at Array.map (<anonymous>)
at asyncForEach (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/helpers/async-for-each.js:6:34)
at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/feature-manager.js:166:9
at async Promise.all (index 0)
at async asyncForEach (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/helpers/async-for-each.js:6:2)
Activity
kovsu commentedon Feb 20, 2025
We need to wait the dom be loaded now. 🥲
fregante commentedon Feb 20, 2025
Is that in
wasClosedLongAgo?I suppose the check can be moved into the observer (addConversationBanner)
kovsu commentedon Feb 24, 2025
In fregante/sandbox#8, every features for
netiquettework fine. Less comments may don't be affected.matthewhively commentedon Mar 27, 2025
I also received this error on page: ktheory/dalli-elasticache#54
kovsu commentedon Mar 28, 2025
@matthewhively Your error is about
netiquettenotrgh-netiquettefregante commentedon Mar 31, 2025
The error is the same:
getLastCloseEventis called too early and it cannot find the closing event.wasClosedLongAgoneeds a minor rework in order to await the React view. Addingdelay(1000)works but obviously not good.jump-to-conversation-close-eventis also affected.I see a few options:
observethe close event, and then act on it (might need a nested observer though)wasClosedLongAgoresolve only once the React view is at least partially loadedwasClosedLongAgoThe
netiquettefeatures can use the API, it's the easiestjump-to-conversation-close-eventstill needs to find the exact element on the page to work, so the first solution is bestrgh-*features are broken #8882