Skip to content

Detect isRepoRoot on branches with slashes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 1 commit into from
Jul 1, 2020
Merged

Detect isRepoRoot on branches with slashes #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,9 @@ collect.set('isRepoHome', [
'https://github.com/sindresorhus/refined-github?files=1',
]);

export const isRepoRoot = (url: URL | Location = location): boolean => /^(tree\/[^/]+)?$/.test(getRepoPath(url)!);
export const isRepoRoot = (url?: URL | Location): boolean =>
/^(tree\/[^/]+)?$/.test(getRepoPath(url ?? location)!) ||
(!url && document.title.startsWith(getRepoURL()) && !document.title.endsWith(getRepoURL())); // #15
collect.set('isRepoRoot', [
...collect.get('isRepoHome') as string[],
'https://github.com/sindresorhus/refined-github/tree/native-copy-buttons',
Expand Down Expand Up @@ -452,7 +454,7 @@ const getCleanPathname = (url: URL | Location = location): string => url.pathnam
/** Parses a repo's subpage
@example '/user/repo/issues/' -> 'issues'
@example '/user/repo/' -> ''
@exampke '/settings/token/' -> undefined
@example '/settings/token/' -> undefined
*/
const getRepoPath = (url: URL | Location = location): string | undefined => {
if (isRepo(url)) {
Expand All @@ -462,8 +464,12 @@ const getRepoPath = (url: URL | Location = location): string | undefined => {
return undefined;
};

/** Get the 'user/repo' part from an URL */
const getRepoURL = (url: URL | Location = location): string => url.pathname.slice(1).split('/', 2).join('/');

Copy link
Member

@fregante fregante Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you import the tests for this function from refined GitHub as well?

Copy link
Member Author

@FloEdelmann FloEdelmann Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't any (or I missed them) 🙁

export const utils = {
getUsername,
getCleanPathname,
getRepoPath,
getRepoURL,
};