Make FieldName Properties Public#353
Conversation
|
hi @zhskay , thank you for your interest in NRedisStack. |
|
Hello @atakavci, thank you for your feedback. Schema schema = new();
foreach (var item in items)
{
// Add fields to the schema with type, name, and other properties based on the item content
} After constructing the schema, I need to compare the existing index with the schema's attributes: foreach (var field in schema.Fields)
{
var attribute = existingIndex.Attributes.FirstOrDefault(a => // Find attribute by field name);
// Compare the attribute with the field
} The issue is that I currently have no way to access the field name for comparison. Regarding the |
5a56187 to
83a0740
Compare
atakavci
left a comment
There was a problem hiding this comment.
ideally each PR code requires the addition/modification of relevant tests, better with integration and unit tests. Since this is pretty straightforward with just exposing existing fields i believe there is not much to test.
thank your contribution and for considering to change alias as private.
LGTM.
Made FieldName properties public
Title
Make
FieldNameProperties PublicDescription
This PR updates the
FieldNameclass by making its properties public. This allows easier comparison of attributes between existing and new Redis indexes before creating, simplifying validation workflows.Changes
FieldNameproperties public.Impact
The change is backward-compatible and improves developer efficiency in index comparisons.