Conversation
fbricon
requested changes
May 30, 2019
Collaborator
fbricon
left a comment
fbricon
left a comment
There was a problem hiding this comment.
Please sign off your commit before merging
Signed-off-by: Yaohai Zheng <yaozheng@microsoft.com>
yaohaizh
force-pushed
the
enableProposedFeature
branch
from
cae6315 to
921a470
Compare
Collaborator
Author
|
@fbricon Updated PR |
fbricon
added a commit
that referenced
this pull request
Jun 5, 2019
The VS Code Marketplace prevents extensions from publishing with
enableProposedApi:true:
ERROR Extensions using proposed API (enableProposedApi: true) can't be published to the Marketplace
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Collaborator
|
Patch reverted due to the Marketplace preventing extensions using that flag from publishing. See c945683 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable proposed API since the call hierarchy & selectionRange is in insider version yet Java LS is mostly feature ready for these features. Would like to bring these features to the customers ASAP.