Skip to content

Add command to add/remove/list the project's source path - #724

Merged
yaohaizh merged 1 commit into
redhat-developer:masterfrom
testforstephen:jinbo_buildpath
Dec 17, 2018
Merged

yaohaizh merged 1 commit into
redhat-developer:masterfrom
testforstephen:jinbo_buildpath

Conversation

@testforstephen

@testforstephen testforstephen commented Nov 20, 2018 •

Copy link
Copy Markdown
Collaborator

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

This is for feature #619, it provides the UI to operate the project's source path.

  • Add Folder to Java Source Path (context menu)
  • Remove Folder from Java Source Path (context menu)
  • List all Java source paths (command palette)

Fixes #619

@fbricon

fbricon commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator

This should only be enabled for non maven/gradle projects. Introducing IDE specific source folders would introduce a mismatch with CLI build tools

@testforstephen

Copy link
Copy Markdown
Collaborator Author

agreed. that's exactly what i did on eclipse.jdt.ls side.

@fbricon

fbricon commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator
  • add source folder
  • add new class in new source folder
  • generate a compilation error (missing type), new diagnostic is added
  • remove source folder
  • diagnostic is not purged

@fbricon

fbricon commented Dec 17, 2018 •

Copy link
Copy Markdown
Collaborator

@testforstephen please squash and rebase this into 1 commit, then @yaohaizh can merge it.

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@yaohaizh
yaohaizh merged commit 7207f40 into redhat-developer:master Dec 17, 2018
@testforstephen
testforstephen deleted the jinbo_buildpath branch December 17, 2018 05:50
@yaohaizh

Copy link
Copy Markdown
Collaborator

@fbricon Done. Merged both PR

@amosbird

Copy link
Copy Markdown

Does this feature get removed? I cannot find those context manuals when right-clicking on some java source folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need new feature: use as source folder

4 participants