Skip to content

i18n: support Chinese - #2027

Merged
fbricon merged 1 commit into
redhat-developer:masterfrom
Eskibear:nls
Aug 27, 2021
Merged

fbricon merged 1 commit into
redhat-developer:masterfrom
Eskibear:nls

Conversation

@Eskibear

Copy link
Copy Markdown
Contributor

Add Chinese localization for command names.

@fbricon

fbricon commented Jul 15, 2021 •

Copy link
Copy Markdown
Collaborator

How do you test it from a non-Chinese machine?

@Eskibear

Eskibear commented Jul 15, 2021 •

Copy link
Copy Markdown
Contributor Author

install Chinese (Simplified) Language Pack from marketplace.

Or run Configure Display Language from command palette.

Comment thread package.nls.zh.json Resolved
Signed-off-by: Yan Zhang <yanzh@microsoft.com>

@jdneo jdneo left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@Eskibear

Copy link
Copy Markdown
Contributor Author

Do we include this PR in this release?

@fbricon

fbricon commented Aug 26, 2021

Copy link
Copy Markdown
Collaborator

if it's ready, then feel free to merge it

@fbricon
fbricon merged commit 0819f46 into redhat-developer:master Aug 27, 2021
@fbricon fbricon added this to the End September 2021 milestone Aug 27, 2021
@Eskibear
Eskibear deleted the nls branch August 27, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants