Uncaught exception: 'java.project.listSourcePaths' already exists #2331

Activity

1. rgrunber

   added

   bug

   on Feb 24, 2022
2. rgrunber commented on Feb 24, 2022

   

   rgrunber

   on Feb 24, 2022

   Member

   More actions

   I see it as well

   Exception has occurred: Error: command 'java.project.listSourcePaths' already exists
   t u.registerCommand ([/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:93:28683]())
   	at Object.registerCommand ([/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:107:30423]())
   	at ExecuteCommandFeature.register ([/home/rgrunber/git/vscode-java/dist/extension.js:79361:52]())
   	at [/home/rgrunber/git/vscode-java/dist/extension.js:80279:29]()
   	at new Promise (<anonymous>)
   	at LanguageClient.handleRegistrationRequest ([/home/rgrunber/git/vscode-java/dist/extension.js:80265:16]())
   	at [/home/rgrunber/git/vscode-java/dist/extension.js:79913:108]()
   	at handleRequest ([/home/rgrunber/git/vscode-java/dist/extension.js:89822:41]())
   	at processMessageQueue ([/home/rgrunber/git/vscode-java/dist/extension.js:89686:17]())
   	at Immediate._onImmediate ([/home/rgrunber/git/vscode-java/dist/extension.js:89676:13]())
   	at processImmediate (internal[/timers.js:461:21]())
   	at process.callbackTrampoline (internal[/async_hooks.js:131:14]())
   

   It seemed the stacktrace was associated with the language server registering commands to the client side, so I recalled we have https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/plugin.xml#L54-L106 in JDT-LS. Any command there that's also registered on the client side (eg. https://github.com/redhat-developer/vscode-java/blob/master/src/buildpath.ts#L48) would run into this.

   @fbricon @snjeza , is there a reason we register in both places ?

   Looks to me like we have a command on the client side that is just meant to call the same command on the server side. Maybe just using a slightly different name would avoid the clash.
3. rgrunber commented on Feb 28, 2022

   

   rgrunber

   on Feb 28, 2022

   Last edited by rgrunber

   Member

   More actions

   I don't think the exception results in any unwanted behaviour, though I have a simple patch to fix it. I think the issue happens as follows :

   We register a command on the client-side (eg. https://github.com/redhat-developer/vscode-java/blob/master/src/buildpath.ts#L48-L49) that simply calls java.execute.workspaceCommand on the server side with the same named command id. That command id is also registered by the server to the client. See https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java#L350-L351 & https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/plugin.xml#L74 .

   The client side is registered first and the server side fails to register its command (already exists). However, I don't think this is an issue because we call the server side commands through `java.execute.workspaceCommand , and not directly.

   Update : Yup, https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/common/client.ts#L2887-L2891 handles the registration of the commands passed to workspace/executeCommand coming from the server. It registers a command with the same ID. So one could do vscode.commands.executeCommand(ID) or vscode.commands.executeCommand("java.workspace.executeCommand", ID) and both should work.

   👍React with 👍1Reacted by Snjeza
4. rgrunber

   added a commit that references this issue on Mar 9, 2022

   Ensure that client-side commands do not clash with server-side.

   ...

   This issue will close once commit 29b1ae7 is merged into the 'main' branch.

   29b1ae7
5. rgrunber

   added a commit that references this issue on Mar 16, 2022

   Ensure that client-side commands do not clash with server-side.

   ...

   This issue will close once commit 55ccfb6 is merged into the 'main' branch.

   55ccfb6
6. rgrunber

   added this to the End March 2022 milestone on Mar 16, 2022
7. rgrunber

   closed this as completedin #2349on Mar 16, 2022
8. rgrunber

   added a commit that references this issue on Mar 16, 2022

   Ensure that client-side commands do not clash with server-side.

   ...

   This issue will close once commit ca9e8cc is merged into the 'main' branch.

   ca9e8cc